-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ClickHouse driver #262
Comments
@cypriss or @taylorchu as you are the authors of this library. Thanks |
I think you can start with a dialect here: https://github.com/gocraft/dbr/tree/master/dialect clickhouse is surprisingly similar to mysql in its query. |
@taylorchu PR is ready here #264 I cannot make circleci run because I'm not a user of the org, I guess. Is that something you can trigger? Locally, tests pass |
could you register on circleci and see if that unlocks you? |
I did register, with the same email I use for github, and linked my github account too, but it still shows |
@taylorchu I managed to get circleci running. Seemed that my github integration was not ok. Fixed one test that was failing and had to upgrade circleci golang image as it was outdated. Tests are passing now, so it's ready to be reviewed. Thanks in advance! |
Hey, I'm Santiago Leira and I work at Embrace as a Software Engineer.
At Embrace, we did a fork of the library and we added support for ClickHouse and we would like to contribute to the main repository with this integration.
Do you have the contribution guide to know how can we add support to ClickHouse here?
Thanks
The text was updated successfully, but these errors were encountered: