Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Cost Analytics #762

Open
qmhu opened this issue May 6, 2023 · 5 comments
Open

Improvements for Cost Analytics #762

qmhu opened this issue May 6, 2023 · 5 comments
Labels
bootcamp help wanted Extra attention is needed

Comments

@qmhu
Copy link
Member

qmhu commented May 6, 2023

Describe the feature

Please find bugs or improvements for Cost Analytics Dashboard in Crane or Grafana. for example:

  • improve the promql query
  • support more dashboards
  • find bugs for current dashboards
@qmhu qmhu added help wanted Extra attention is needed bootcamp labels May 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

Hello @qmhu.
We totally like your proposal/feedback, welcome to send us a Pull Request for it.
Please send your Pull Request to main branch, fill the Pull Request Template here, provide changelog/documentation/test cases if needed and make sure CI passed, we will review it soon.
We appreciate your effort in advance and looking forward to your contribution!

你好 @qmhu,我们完全同意你的提议/反馈。
欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。
请将 Pull Request 发到 main 分支,务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、测试用例、文档等,并确保 CI 通过。
我们会尽快进行 Review,提前感谢和期待您的贡献。

@qingtiantongxie
Copy link
Contributor

qingtiantongxie commented May 11, 2023

Hi, for the third point, find bugs for current dashboards, i have sth to say.

My mac use the dark theme. Under the dark theme, the dashboard search form cannot be normally used , so i submitted a bug feedback and i fixed it.

here is the feedback : #756

here is the pr: #761

just as u see this is just one line code change, so ...I didn't expect to get an effective PR, but i still took some time to find and fix it , so should i get an effective bug report ?

thanks u for reading :)

@qmhu
Copy link
Member Author

qmhu commented May 12, 2023

Hi, for the third point, find bugs for current dashboards, i have sth to say.

My mac use the dark theme. Under the dark theme, the dashboard search form cannot be normally used , so i submitted a bug feedback and i fixed it.

here is the feedback : #756

here is the pr: #761

just as u see this is just one line code change, so ...I didn't expect to get an effective PR, but i still took some time to find and fix it , so should i get an effective bug report ?

thanks u for reading :)
can you try #788 ?

@qingtiantongxie
Copy link
Contributor

Hi, for the third point, find bugs for current dashboards, i have sth to say.
My mac use the dark theme. Under the dark theme, the dashboard search form cannot be normally used , so i submitted a bug feedback and i fixed it.
here is the feedback : #756
here is the pr: #761
just as u see this is just one line code change, so ...I didn't expect to get an effective PR, but i still took some time to find and fix it , so should i get an effective bug report ?
thanks u for reading :)
can you try #788 ?

Well, i saw #788 has been fixed by someone, see #790 . so what happened to it ?

And we're now talking about why I meet the activity rules but can't get the corresponding points ? re-read your scoring rules, it says 'Grane 项目 bug 反馈被采纳' right ? it's really disappointing and sad :( .

if u want me to do #788 , tell me what is really count

@qmhu
Copy link
Member Author

qmhu commented May 15, 2023

Hi, for the third point, find bugs for current dashboards, i have sth to say.
My mac use the dark theme. Under the dark theme, the dashboard search form cannot be normally used , so i submitted a bug feedback and i fixed it.
here is the feedback : #756
here is the pr: #761
just as u see this is just one line code change, so ...I didn't expect to get an effective PR, but i still took some time to find and fix it , so should i get an effective bug report ?
thanks u for reading :)
can you try #788 ?

Well, i saw #788 has been fixed by someone, see #790 . so what happened to it ?

And we're now talking about why I meet the activity rules but can't get the corresponding points ? re-read your scoring rules, it says 'Grane 项目 bug 反馈被采纳' right ? it's really disappointing and sad :( .

if u want me to do #788 , tell me what is really count

#790 isn't fixed now, so my suggestion is ether you can try to fix #788 or find other items to do, for example some functional improvement or functional bugs.

If you don't want a bootcamp label, we accept all improvements if it's right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootcamp help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants