Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer copy text and social icons footer containers display when content hasn't been added. #40

Closed
1 of 3 tasks
jrtashjian opened this issue Jul 16, 2019 · 0 comments
Closed
1 of 3 tasks

Comments

@jrtashjian
Copy link
Member

jrtashjian commented Jul 16, 2019

Describe the bug:

If no content has been added to the Customizer > Footer Settings > Social Icons or Customizer > Footer Settings > Footer Text > Copyright Text, the .row--2 container is still rendered with borders and spacing.

Expected behavior:

The HTML should either not render or there should be a default copyright text shown if nothing has been set. The social icons HTML should just not render unless links exist.

Screenshot(s):

Customizer changeset link: https://godaddy.10uplabs.com/traditional/?customize_changeset_uuid=170dcbfe-2812-4d09-9fa5-19a13bc598c3

Screenshot from 2019-07-16 15-01-36

Priority:

  • High - Functional blocker
  • Medium - Doesn't work as expected
  • Low - Not a big deal but we'd want to get to this eventually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants