Release 1.4.3 (#44)

* Fix deploy task

* Add npmrc

* Update travis config

* Support banners and youtube in readme, add video

* Use hqdefault for video thumbnail

* GoLF Automated checkin by kchien (2/21/2017 4:30:02 PM)

* Update cssmin package ver

* Fix makepot task

* Update POT

* Update mo

* Bump tested up to 4.8

* Bump tested up to

* Switch wp_nonce to _wpnonce. Fix failing check_admin_referer when action === 'refresh'

* Update devDependencies

* set dist: precise for 5.2

* set dist: precise for 5.2

* Temporarily disable PHP 5.2. See travis-ci/travis-ci#8072

* Update dev dependencies. Re-grunt

* Update changelog with 1.2.1 changes

* Change Text Domain to Match WordPress.org Plugin Slug (#26)

* update text domain for interested translators on translation.wordpress.org to work on plugin strings.

* change text domain to match plugin slug in comments

* fixing according to travis ci warnings

only the i18n warnings.

* more fixes based on travis ci output

* fixing other warnings

* one more warning

* renamed language files to match text domain

https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain

* Add GDPR Support (#28)

* Add support for GDPR fields.

* Update gruntfile and npm dependencies

* Add comment for tos_link

* Resolve PHPCS warnings. Update phpcs.ruleset.xml.

* Remove test filter

* Add xmllint addon to travis build config

* Double check for method before calling it. Update checkbox field value to match disply text.

* Update gem-form-fields test to asset invalid_field_type returns empty.

* Readd vendor dir to PHPCS exclusion

* Add test for tos_link

* Add test for tracking_option

* Remove chrome from travis addons

* Remove print

* Add spacing for phpcs warnings

* Add required checkboxes to error checking

* Update update-pot grunt task. Regenerate translations after i18n function updates and updated i18n comments

* Update read for 1.3.0 release

* [dist] update packages

* [dist] New package-lock

* Introduce GEM Gutenberg block (#31)

* Start to build out GEM gutenberg block

* Save block output with proper shortcode

* Add .babelrbs and webpack.config.js to .distignore

* Resolve PHPCS warnings

* Dynamically generate the GEM form in the GEM block

* Bump tested up to version to 5.0

* Fix PHPCS spacing

* Dynamic gem block

* Update dynamic blocks

* Add GEM block screenshots and update readme

* Clean up UX during block addition/form selection. Cleanup JS file.

* Add docblock to class prop

* Update changelog, regenerate readme

* Update GEM select field label

* Update godaddy-email-marketing-sign-up-forms-ru_RU.po (#33)

Added RU for several messages (Thank you for signing up, There was a problem).

* Fix cache being bypassed when fetching forms (#34)

* Regenerate mo files. Update changelog for 1.4.1. Regerate readme.md

* Fix help tab iframe url with www (#37)

* Fix help tab iframe URL for non-US locales

* Fix help tab iframe URL for non-US locales

* Update readme with 1.4.2 changes

* Bump tested up to to 5.2

* Remove $ reference and fix SVG icon (#39)

* Remove $ reference and fix SVG icon

* Remove console log from testing

* Test plugin with WP 5.4 and minor style fix (#40)

* Remove $ reference and fix SVG icon

* Remove console log from testing

* updated for 5.4

* tweak readme

* revert version bump changes

* fix json

Co-authored-by: Evan Herman <evan.m.herman@gmail.com>
Co-authored-by: Evan Herman <evanmherman@gmail.com>

* Update readme for 1.4.3 release (#43)

Co-authored-by: Frankie Jarrett <fjarrett@gmail.com>
Co-authored-by: GoLF <loc-support@godaddy.com>
Co-authored-by: Robert Sim <robertsky@users.noreply.github.com>
Co-authored-by: Jonathan Bardo <bardo.jonathan@gmail.com>
Co-authored-by: beebeatle <ab2009ukr@gmail.com>
Co-authored-by: Aaron D. Campbell <aaron@xavisys.com>
Co-authored-by: Anthony Ledesma <30462574+AnthonyLedesma@users.noreply.github.com>

.travis.yml

@@ -12,7 +12,7 @@ php:
   - 7.1
 
 env:
-  - WP_VERSION=3.8 WP_MULTISITE=0
+  - WP_VERSION=5.4 WP_MULTISITE=0
   - WP_VERSION=latest WP_MULTISITE=0
   - WP_VERSION=trunk WP_MULTISITE=0
 
@@ -26,9 +26,9 @@ matrix:
   fast_finish: true
   exclude:
     - php: 5.6
-      env: WP_VERSION=3.8 WP_MULTISITE=0
+      env: WP_VERSION=5.4 WP_MULTISITE=0
     - php: 7.1
-      env: WP_VERSION=3.8 WP_MULTISITE=0
+      env: WP_VERSION=5.4 WP_MULTISITE=0
 
 install:
   - composer config -g github-oauth.github.com $GITHUB_TOKEN

css/blocks.css

@@ -5,4 +5,9 @@
 .wp-block-godaddy-email-marketing-sign-up-forms-gem-block .preloader {
 	display: block;
 	margin: 2em auto;
+	max-width: 20px;
+}
+
+.wp-block-godaddy-email-marketing-sign-up-forms-gem-block label {
+	margin-right: 12px;
 }

includes/blocks/blocks.js

@@ -1,3 +1,4 @@
+
 // Locale
 import './i18n.js';
 import gemIcons from './icons';
@@ -110,17 +111,17 @@ function renderGemForm( formID ) {
     'formID': formID,
   };
 
-  $.post( ajaxurl, data, function( response ) {
+  jQuery.post( ajaxurl, data, function( response ) {
 
     if ( ! response.success ) {
 
-      $( '.gem-form' ).html( gem.getFormError );
+      jQuery( '.gem-form' ).html( gem.getFormError );
 
       return;
 
     }
 
-    $( '.gem-form' ).html( response.data );
+    jQuery( '.gem-form' ).html( response.data );
 
   } );
 

includes/blocks/icons.js

@@ -1,17 +1,10 @@
 const gemIcons = {};
 
-gemIcons.mail = <svg
-  xmlns="http://www.w3.org/2000/svg"
-  width="20pt"
-  height="22pt"
-  viewBox="0 0 20 22"
-  version="1.1"
->
-  <g id="surface1">
-    <path style={{ stroke: 'none', fillRule: 'nonzero', fill: 'rgb(23.137255%,76.078431%,18.039216%)', fillOpacity: '1' }} d="M 0.0390625, 11.097656 L 1.925781, 22 L 19.960938, 18.109375, L 19.960938, 6.890625, L 11.371094, 15.828125, Z M 0.0390625, 11.097656 "/>
-    <path style={{ stroke: 'none', fillRule: 'nonzero', fill: 'rgb(23.137255%,76.078431%,18.039216%)', fillOpacity: '1' }} d="M 9.882812, 6.632812 C 6.785156, 7.230469, 0.164062, 9.597656, 0.164062, 9.597656, L 11.171875, 14.9375, L 19.289062, 5.828125, C 19.289062, 5.816406, 13.042969, 6.011719, 9.882812, 6.632812, Z M 9.882812, 6.632812 "/>
-    <path style={{ stroke: 'none', fillRule: 'nonzero', fill: 'rgb(23.137255%,66.27451%,16.470588%)', fillOpacity: '1' }} d="M 0.164062, 9.597656 C 0.164062, 9.597656, 6.472656, 8.304688, 9.484375, 7.71875, L 19.277344, 5.816406, L 8.628906, 0 Z M 0.164062, 9.597656 "/>
-  </g>
+gemIcons.mail = <svg xmlns="http://www.w3.org/2000/svg" viewBox="-187 279 236 236">
+	<path fill="none" d="M-187 279H49v236h-236V279z"/>
+	<path fill="#3BC22E" d="M-149.3 397.8l15.2 89.4 145.5-31.9v-92l-69.3 73.3-91.4-38.8z"/>
+	<path fill="#3BC22E" d="M-69.9 361.2c-25 4.9-78.4 24.3-78.4 24.3l88.8 43.8L6 354.6c0-.1-50.4 1.5-75.9 6.6z"/>
+	<path fill="#3BA92A" d="M-148.3 385.5s50.9-10.6 75.2-15.4l79-15.6-85.9-47.7-68.3 78.7z"/>
 </svg>;
 
 export default gemIcons;