Fix help tab iframe url with www #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHerman
approved these changes
Jan 19, 2019
There was a problem hiding this comment.
Thanks @aaroncampbell! Good catch. I'm merging this over #36 as I think this is a little bit cleaner of an approach.
EvanHerman
pushed a commit
that referenced
this pull request
Feb 20, 2019
* Fix deploy task * Add npmrc * Update travis config * Support banners and youtube in readme, add video * Use hqdefault for video thumbnail * GoLF Automated checkin by kchien (2/21/2017 4:30:02 PM) * Update cssmin package ver * Fix makepot task * Update POT * Update mo * Bump tested up to 4.8 * Bump tested up to * Switch wp_nonce to _wpnonce. Fix failing check_admin_referer when action === 'refresh' * Update devDependencies * set dist: precise for 5.2 * set dist: precise for 5.2 * Temporarily disable PHP 5.2. See travis-ci/travis-ci#8072 * Update dev dependencies. Re-grunt * Update changelog with 1.2.1 changes * Change Text Domain to Match WordPress.org Plugin Slug (#26) * update text domain for interested translators on translation.wordpress.org to work on plugin strings. * change text domain to match plugin slug in comments * fixing according to travis ci warnings only the i18n warnings. * more fixes based on travis ci output * fixing other warnings * one more warning * renamed language files to match text domain https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain * Add GDPR Support (#28) * Add support for GDPR fields. * Update gruntfile and npm dependencies * Add comment for tos_link * Resolve PHPCS warnings. Update phpcs.ruleset.xml. * Remove test filter * Add xmllint addon to travis build config * Double check for method before calling it. Update checkbox field value to match disply text. * Update gem-form-fields test to asset invalid_field_type returns empty. * Readd vendor dir to PHPCS exclusion * Add test for tos_link * Add test for tracking_option * Remove chrome from travis addons * Remove print * Add spacing for phpcs warnings * Add required checkboxes to error checking * Update update-pot grunt task. Regenerate translations after i18n function updates and updated i18n comments * Update read for 1.3.0 release * [dist] update packages * [dist] New package-lock * Introduce GEM Gutenberg block (#31) * Start to build out GEM gutenberg block * Save block output with proper shortcode * Add .babelrbs and webpack.config.js to .distignore * Resolve PHPCS warnings * Dynamically generate the GEM form in the GEM block * Bump tested up to version to 5.0 * Fix PHPCS spacing * Dynamic gem block * Update dynamic blocks * Add GEM block screenshots and update readme * Clean up UX during block addition/form selection. Cleanup JS file. * Add docblock to class prop * Update changelog, regenerate readme * Update GEM select field label * Update godaddy-email-marketing-sign-up-forms-ru_RU.po (#33) Added RU for several messages (Thank you for signing up, There was a problem). * Fix cache being bypassed when fetching forms (#34) * Regenerate mo files. Update changelog for 1.4.1. Regerate readme.md * Fix help tab iframe url with www (#37) * Fix help tab iframe URL for non-US locales * Fix help tab iframe URL for non-US locales * Update readme with 1.4.2 changes
EvanHerman
pushed a commit
that referenced
this pull request
Apr 13, 2020
* Fix deploy task * Add npmrc * Update travis config * Support banners and youtube in readme, add video * Use hqdefault for video thumbnail * GoLF Automated checkin by kchien (2/21/2017 4:30:02 PM) * Update cssmin package ver * Fix makepot task * Update POT * Update mo * Bump tested up to 4.8 * Bump tested up to * Switch wp_nonce to _wpnonce. Fix failing check_admin_referer when action === 'refresh' * Update devDependencies * set dist: precise for 5.2 * set dist: precise for 5.2 * Temporarily disable PHP 5.2. See travis-ci/travis-ci#8072 * Update dev dependencies. Re-grunt * Update changelog with 1.2.1 changes * Change Text Domain to Match WordPress.org Plugin Slug (#26) * update text domain for interested translators on translation.wordpress.org to work on plugin strings. * change text domain to match plugin slug in comments * fixing according to travis ci warnings only the i18n warnings. * more fixes based on travis ci output * fixing other warnings * one more warning * renamed language files to match text domain https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain * Add GDPR Support (#28) * Add support for GDPR fields. * Update gruntfile and npm dependencies * Add comment for tos_link * Resolve PHPCS warnings. Update phpcs.ruleset.xml. * Remove test filter * Add xmllint addon to travis build config * Double check for method before calling it. Update checkbox field value to match disply text. * Update gem-form-fields test to asset invalid_field_type returns empty. * Readd vendor dir to PHPCS exclusion * Add test for tos_link * Add test for tracking_option * Remove chrome from travis addons * Remove print * Add spacing for phpcs warnings * Add required checkboxes to error checking * Update update-pot grunt task. Regenerate translations after i18n function updates and updated i18n comments * Update read for 1.3.0 release * [dist] update packages * [dist] New package-lock * Introduce GEM Gutenberg block (#31) * Start to build out GEM gutenberg block * Save block output with proper shortcode * Add .babelrbs and webpack.config.js to .distignore * Resolve PHPCS warnings * Dynamically generate the GEM form in the GEM block * Bump tested up to version to 5.0 * Fix PHPCS spacing * Dynamic gem block * Update dynamic blocks * Add GEM block screenshots and update readme * Clean up UX during block addition/form selection. Cleanup JS file. * Add docblock to class prop * Update changelog, regenerate readme * Update GEM select field label * Update godaddy-email-marketing-sign-up-forms-ru_RU.po (#33) Added RU for several messages (Thank you for signing up, There was a problem). * Fix cache being bypassed when fetching forms (#34) * Regenerate mo files. Update changelog for 1.4.1. Regerate readme.md * Fix help tab iframe url with www (#37) * Fix help tab iframe URL for non-US locales * Fix help tab iframe URL for non-US locales * Update readme with 1.4.2 changes * Bump tested up to to 5.2 * Remove $ reference and fix SVG icon (#39) * Remove $ reference and fix SVG icon * Remove console log from testing * Test plugin with WP 5.4 and minor style fix (#40) * Remove $ reference and fix SVG icon * Remove console log from testing * updated for 5.4 * tweak readme * revert version bump changes * fix json Co-authored-by: Evan Herman <evan.m.herman@gmail.com> Co-authored-by: Evan Herman <evanmherman@gmail.com> * Update readme for 1.4.3 release (#43) Co-authored-by: Frankie Jarrett <fjarrett@gmail.com> Co-authored-by: GoLF <loc-support@godaddy.com> Co-authored-by: Robert Sim <robertsky@users.noreply.github.com> Co-authored-by: Jonathan Bardo <bardo.jonathan@gmail.com> Co-authored-by: beebeatle <ab2009ukr@gmail.com> Co-authored-by: Aaron D. Campbell <aaron@xavisys.com> Co-authored-by: Anthony Ledesma <30462574+AnthonyLedesma@users.noreply.github.com>
EvanHerman
added a commit
that referenced
this pull request
Jun 8, 2021
* Fix deploy task * Add npmrc * Update travis config * Support banners and youtube in readme, add video * Use hqdefault for video thumbnail * GoLF Automated checkin by kchien (2/21/2017 4:30:02 PM) * Update cssmin package ver * Fix makepot task * Update POT * Update mo * Bump tested up to 4.8 * Bump tested up to * Switch wp_nonce to _wpnonce. Fix failing check_admin_referer when action === 'refresh' * Update devDependencies * set dist: precise for 5.2 * set dist: precise for 5.2 * Temporarily disable PHP 5.2. See travis-ci/travis-ci#8072 * Update dev dependencies. Re-grunt * Update changelog with 1.2.1 changes * Change Text Domain to Match WordPress.org Plugin Slug (#26) * update text domain for interested translators on translation.wordpress.org to work on plugin strings. * change text domain to match plugin slug in comments * fixing according to travis ci warnings only the i18n warnings. * more fixes based on travis ci output * fixing other warnings * one more warning * renamed language files to match text domain https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain * Add GDPR Support (#28) * Add support for GDPR fields. * Update gruntfile and npm dependencies * Add comment for tos_link * Resolve PHPCS warnings. Update phpcs.ruleset.xml. * Remove test filter * Add xmllint addon to travis build config * Double check for method before calling it. Update checkbox field value to match disply text. * Update gem-form-fields test to asset invalid_field_type returns empty. * Readd vendor dir to PHPCS exclusion * Add test for tos_link * Add test for tracking_option * Remove chrome from travis addons * Remove print * Add spacing for phpcs warnings * Add required checkboxes to error checking * Update update-pot grunt task. Regenerate translations after i18n function updates and updated i18n comments * Update read for 1.3.0 release * [dist] update packages * [dist] New package-lock * Introduce GEM Gutenberg block (#31) * Start to build out GEM gutenberg block * Save block output with proper shortcode * Add .babelrbs and webpack.config.js to .distignore * Resolve PHPCS warnings * Dynamically generate the GEM form in the GEM block * Bump tested up to version to 5.0 * Fix PHPCS spacing * Dynamic gem block * Update dynamic blocks * Add GEM block screenshots and update readme * Clean up UX during block addition/form selection. Cleanup JS file. * Add docblock to class prop * Update changelog, regenerate readme * Update GEM select field label * Update godaddy-email-marketing-sign-up-forms-ru_RU.po (#33) Added RU for several messages (Thank you for signing up, There was a problem). * Fix cache being bypassed when fetching forms (#34) * Regenerate mo files. Update changelog for 1.4.1. Regerate readme.md * Fix help tab iframe url with www (#37) * Fix help tab iframe URL for non-US locales * Fix help tab iframe URL for non-US locales * Update readme with 1.4.2 changes * Bump tested up to to 5.2 * Remove $ reference and fix SVG icon (#39) * Remove $ reference and fix SVG icon * Remove console log from testing * Test plugin with WP 5.4 and minor style fix (#40) * Remove $ reference and fix SVG icon * Remove console log from testing * updated for 5.4 * tweak readme * revert version bump changes * fix json Co-authored-by: Evan Herman <evan.m.herman@gmail.com> Co-authored-by: Evan Herman <evanmherman@gmail.com> * Update readme for 1.4.3 release (#43) * remove grunt-dev-update dependency (#46) * Add PHP linting (#47) * Adding php linting * automated fixes * fix all phpcs errors * phpcs fixes Co-authored-by: AnthonyLedesma <anthonymledesma@gmail.com> * Bump tested up to 5.7 (#65) * Bump tested up to 5.7 * Bump dealerdirect/phpcodesniffer-composer-installer Co-authored-by: Frankie Jarrett <fjarrett@gmail.com> Co-authored-by: GoLF <loc-support@godaddy.com> Co-authored-by: Robert Sim <robertsky@users.noreply.github.com> Co-authored-by: Evan Herman <evanmherman@gmail.com> Co-authored-by: Jonathan Bardo <bardo.jonathan@gmail.com> Co-authored-by: beebeatle <ab2009ukr@gmail.com> Co-authored-by: Aaron D. Campbell <aaron@xavisys.com> Co-authored-by: Anthony Ledesma <30462574+AnthonyLedesma@users.noreply.github.com> Co-authored-by: JR Tashjian <jrtashjian@gmail.com> Co-authored-by: AnthonyLedesma <anthonymledesma@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #36 - This is just an alternative to that, only one needs to be merged.