-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GDPR Support #28
Add GDPR Support #28
Conversation
includes/render.php
Outdated
@@ -28,7 +28,7 @@ class GEM_Form_Renderer { | |||
* @return string | |||
*/ | |||
public function process( $form_id, $echo = false ) { | |||
$form = GEM_Dispatcher::get_fields( (int) $form_id ); | |||
$form = (object) apply_filters( 'test', GEM_Dispatcher::get_fields( (int) $form_id ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EvanHerman Pretty sure test
is not the tag name you had in mind here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, that should have been removed :D
@EvanHerman Can you post some screenshots of what to expect in the UI as a result of this PR? |
…e to match disply text.
* Fix deploy task * Add npmrc * Update travis config * Support banners and youtube in readme, add video * Use hqdefault for video thumbnail * GoLF Automated checkin by kchien (2/21/2017 4:30:02 PM) * Update cssmin package ver * Fix makepot task * Update POT * Update mo * Bump tested up to 4.8 * Bump tested up to * Switch wp_nonce to _wpnonce. Fix failing check_admin_referer when action === 'refresh' * Update devDependencies * set dist: precise for 5.2 * set dist: precise for 5.2 * Temporarily disable PHP 5.2. See travis-ci/travis-ci#8072 * Update dev dependencies. Re-grunt * Update changelog with 1.2.1 changes * Change Text Domain to Match WordPress.org Plugin Slug (#26) * update text domain for interested translators on translation.wordpress.org to work on plugin strings. * change text domain to match plugin slug in comments * fixing according to travis ci warnings only the i18n warnings. * more fixes based on travis ci output * fixing other warnings * one more warning * renamed language files to match text domain https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain * Add GDPR Support (#28) * Add support for GDPR fields. * Update gruntfile and npm dependencies * Add comment for tos_link * Resolve PHPCS warnings. Update phpcs.ruleset.xml. * Remove test filter * Add xmllint addon to travis build config * Double check for method before calling it. Update checkbox field value to match disply text. * Update gem-form-fields test to asset invalid_field_type returns empty. * Readd vendor dir to PHPCS exclusion * Add test for tos_link * Add test for tracking_option * Remove chrome from travis addons * Remove print * Add spacing for phpcs warnings * Add required checkboxes to error checking * Update update-pot grunt task. Regenerate translations after i18n function updates and updated i18n comments * Update read for 1.3.0 release
* Fix deploy task * Add npmrc * Update travis config * Support banners and youtube in readme, add video * Use hqdefault for video thumbnail * GoLF Automated checkin by kchien (2/21/2017 4:30:02 PM) * Update cssmin package ver * Fix makepot task * Update POT * Update mo * Bump tested up to 4.8 * Bump tested up to * Switch wp_nonce to _wpnonce. Fix failing check_admin_referer when action === 'refresh' * Update devDependencies * set dist: precise for 5.2 * set dist: precise for 5.2 * Temporarily disable PHP 5.2. See travis-ci/travis-ci#8072 * Update dev dependencies. Re-grunt * Update changelog with 1.2.1 changes * Change Text Domain to Match WordPress.org Plugin Slug (#26) * update text domain for interested translators on translation.wordpress.org to work on plugin strings. * change text domain to match plugin slug in comments * fixing according to travis ci warnings only the i18n warnings. * more fixes based on travis ci output * fixing other warnings * one more warning * renamed language files to match text domain https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain * Add GDPR Support (#28) * Add support for GDPR fields. * Update gruntfile and npm dependencies * Add comment for tos_link * Resolve PHPCS warnings. Update phpcs.ruleset.xml. * Remove test filter * Add xmllint addon to travis build config * Double check for method before calling it. Update checkbox field value to match disply text. * Update gem-form-fields test to asset invalid_field_type returns empty. * Readd vendor dir to PHPCS exclusion * Add test for tos_link * Add test for tracking_option * Remove chrome from travis addons * Remove print * Add spacing for phpcs warnings * Add required checkboxes to error checking * Update update-pot grunt task. Regenerate translations after i18n function updates and updated i18n comments * Update read for 1.3.0 release * [dist] update packages * [dist] New package-lock
* Fix deploy task * Add npmrc * Update travis config * Support banners and youtube in readme, add video * Use hqdefault for video thumbnail * GoLF Automated checkin by kchien (2/21/2017 4:30:02 PM) * Update cssmin package ver * Fix makepot task * Update POT * Update mo * Bump tested up to 4.8 * Bump tested up to * Switch wp_nonce to _wpnonce. Fix failing check_admin_referer when action === 'refresh' * Update devDependencies * set dist: precise for 5.2 * set dist: precise for 5.2 * Temporarily disable PHP 5.2. See travis-ci/travis-ci#8072 * Update dev dependencies. Re-grunt * Update changelog with 1.2.1 changes * Change Text Domain to Match WordPress.org Plugin Slug (#26) * update text domain for interested translators on translation.wordpress.org to work on plugin strings. * change text domain to match plugin slug in comments * fixing according to travis ci warnings only the i18n warnings. * more fixes based on travis ci output * fixing other warnings * one more warning * renamed language files to match text domain https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain * Add GDPR Support (#28) * Add support for GDPR fields. * Update gruntfile and npm dependencies * Add comment for tos_link * Resolve PHPCS warnings. Update phpcs.ruleset.xml. * Remove test filter * Add xmllint addon to travis build config * Double check for method before calling it. Update checkbox field value to match disply text. * Update gem-form-fields test to asset invalid_field_type returns empty. * Readd vendor dir to PHPCS exclusion * Add test for tos_link * Add test for tracking_option * Remove chrome from travis addons * Remove print * Add spacing for phpcs warnings * Add required checkboxes to error checking * Update update-pot grunt task. Regenerate translations after i18n function updates and updated i18n comments * Update read for 1.3.0 release * [dist] update packages * [dist] New package-lock * Introduce GEM Gutenberg block (#31) * Start to build out GEM gutenberg block * Save block output with proper shortcode * Add .babelrbs and webpack.config.js to .distignore * Resolve PHPCS warnings * Dynamically generate the GEM form in the GEM block * Bump tested up to version to 5.0 * Fix PHPCS spacing * Dynamic gem block * Update dynamic blocks * Add GEM block screenshots and update readme * Clean up UX during block addition/form selection. Cleanup JS file. * Add docblock to class prop * Update changelog, regenerate readme
* Fix deploy task * Add npmrc * Update travis config * Support banners and youtube in readme, add video * Use hqdefault for video thumbnail * GoLF Automated checkin by kchien (2/21/2017 4:30:02 PM) * Update cssmin package ver * Fix makepot task * Update POT * Update mo * Bump tested up to 4.8 * Bump tested up to * Switch wp_nonce to _wpnonce. Fix failing check_admin_referer when action === 'refresh' * Update devDependencies * set dist: precise for 5.2 * set dist: precise for 5.2 * Temporarily disable PHP 5.2. See travis-ci/travis-ci#8072 * Update dev dependencies. Re-grunt * Update changelog with 1.2.1 changes * Change Text Domain to Match WordPress.org Plugin Slug (#26) * update text domain for interested translators on translation.wordpress.org to work on plugin strings. * change text domain to match plugin slug in comments * fixing according to travis ci warnings only the i18n warnings. * more fixes based on travis ci output * fixing other warnings * one more warning * renamed language files to match text domain https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain * Add GDPR Support (#28) * Add support for GDPR fields. * Update gruntfile and npm dependencies * Add comment for tos_link * Resolve PHPCS warnings. Update phpcs.ruleset.xml. * Remove test filter * Add xmllint addon to travis build config * Double check for method before calling it. Update checkbox field value to match disply text. * Update gem-form-fields test to asset invalid_field_type returns empty. * Readd vendor dir to PHPCS exclusion * Add test for tos_link * Add test for tracking_option * Remove chrome from travis addons * Remove print * Add spacing for phpcs warnings * Add required checkboxes to error checking * Update update-pot grunt task. Regenerate translations after i18n function updates and updated i18n comments * Update read for 1.3.0 release * [dist] update packages * [dist] New package-lock * Introduce GEM Gutenberg block (#31) * Start to build out GEM gutenberg block * Save block output with proper shortcode * Add .babelrbs and webpack.config.js to .distignore * Resolve PHPCS warnings * Dynamically generate the GEM form in the GEM block * Bump tested up to version to 5.0 * Fix PHPCS spacing * Dynamic gem block * Update dynamic blocks * Add GEM block screenshots and update readme * Clean up UX during block addition/form selection. Cleanup JS file. * Add docblock to class prop * Update changelog, regenerate readme * Update GEM select field label * Update godaddy-email-marketing-sign-up-forms-ru_RU.po (#33) Added RU for several messages (Thank you for signing up, There was a problem). * Fix cache being bypassed when fetching forms (#34) * Regenerate mo files. Update changelog for 1.4.1. Regerate readme.md
* Fix deploy task * Add npmrc * Update travis config * Support banners and youtube in readme, add video * Use hqdefault for video thumbnail * GoLF Automated checkin by kchien (2/21/2017 4:30:02 PM) * Update cssmin package ver * Fix makepot task * Update POT * Update mo * Bump tested up to 4.8 * Bump tested up to * Switch wp_nonce to _wpnonce. Fix failing check_admin_referer when action === 'refresh' * Update devDependencies * set dist: precise for 5.2 * set dist: precise for 5.2 * Temporarily disable PHP 5.2. See travis-ci/travis-ci#8072 * Update dev dependencies. Re-grunt * Update changelog with 1.2.1 changes * Change Text Domain to Match WordPress.org Plugin Slug (#26) * update text domain for interested translators on translation.wordpress.org to work on plugin strings. * change text domain to match plugin slug in comments * fixing according to travis ci warnings only the i18n warnings. * more fixes based on travis ci output * fixing other warnings * one more warning * renamed language files to match text domain https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain * Add GDPR Support (#28) * Add support for GDPR fields. * Update gruntfile and npm dependencies * Add comment for tos_link * Resolve PHPCS warnings. Update phpcs.ruleset.xml. * Remove test filter * Add xmllint addon to travis build config * Double check for method before calling it. Update checkbox field value to match disply text. * Update gem-form-fields test to asset invalid_field_type returns empty. * Readd vendor dir to PHPCS exclusion * Add test for tos_link * Add test for tracking_option * Remove chrome from travis addons * Remove print * Add spacing for phpcs warnings * Add required checkboxes to error checking * Update update-pot grunt task. Regenerate translations after i18n function updates and updated i18n comments * Update read for 1.3.0 release * [dist] update packages * [dist] New package-lock * Introduce GEM Gutenberg block (#31) * Start to build out GEM gutenberg block * Save block output with proper shortcode * Add .babelrbs and webpack.config.js to .distignore * Resolve PHPCS warnings * Dynamically generate the GEM form in the GEM block * Bump tested up to version to 5.0 * Fix PHPCS spacing * Dynamic gem block * Update dynamic blocks * Add GEM block screenshots and update readme * Clean up UX during block addition/form selection. Cleanup JS file. * Add docblock to class prop * Update changelog, regenerate readme * Update GEM select field label * Update godaddy-email-marketing-sign-up-forms-ru_RU.po (#33) Added RU for several messages (Thank you for signing up, There was a problem). * Fix cache being bypassed when fetching forms (#34) * Regenerate mo files. Update changelog for 1.4.1. Regerate readme.md * Fix help tab iframe url with www (#37) * Fix help tab iframe URL for non-US locales * Fix help tab iframe URL for non-US locales * Update readme with 1.4.2 changes
* Fix deploy task * Add npmrc * Update travis config * Support banners and youtube in readme, add video * Use hqdefault for video thumbnail * GoLF Automated checkin by kchien (2/21/2017 4:30:02 PM) * Update cssmin package ver * Fix makepot task * Update POT * Update mo * Bump tested up to 4.8 * Bump tested up to * Switch wp_nonce to _wpnonce. Fix failing check_admin_referer when action === 'refresh' * Update devDependencies * set dist: precise for 5.2 * set dist: precise for 5.2 * Temporarily disable PHP 5.2. See travis-ci/travis-ci#8072 * Update dev dependencies. Re-grunt * Update changelog with 1.2.1 changes * Change Text Domain to Match WordPress.org Plugin Slug (#26) * update text domain for interested translators on translation.wordpress.org to work on plugin strings. * change text domain to match plugin slug in comments * fixing according to travis ci warnings only the i18n warnings. * more fixes based on travis ci output * fixing other warnings * one more warning * renamed language files to match text domain https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain * Add GDPR Support (#28) * Add support for GDPR fields. * Update gruntfile and npm dependencies * Add comment for tos_link * Resolve PHPCS warnings. Update phpcs.ruleset.xml. * Remove test filter * Add xmllint addon to travis build config * Double check for method before calling it. Update checkbox field value to match disply text. * Update gem-form-fields test to asset invalid_field_type returns empty. * Readd vendor dir to PHPCS exclusion * Add test for tos_link * Add test for tracking_option * Remove chrome from travis addons * Remove print * Add spacing for phpcs warnings * Add required checkboxes to error checking * Update update-pot grunt task. Regenerate translations after i18n function updates and updated i18n comments * Update read for 1.3.0 release * [dist] update packages * [dist] New package-lock * Introduce GEM Gutenberg block (#31) * Start to build out GEM gutenberg block * Save block output with proper shortcode * Add .babelrbs and webpack.config.js to .distignore * Resolve PHPCS warnings * Dynamically generate the GEM form in the GEM block * Bump tested up to version to 5.0 * Fix PHPCS spacing * Dynamic gem block * Update dynamic blocks * Add GEM block screenshots and update readme * Clean up UX during block addition/form selection. Cleanup JS file. * Add docblock to class prop * Update changelog, regenerate readme * Update GEM select field label * Update godaddy-email-marketing-sign-up-forms-ru_RU.po (#33) Added RU for several messages (Thank you for signing up, There was a problem). * Fix cache being bypassed when fetching forms (#34) * Regenerate mo files. Update changelog for 1.4.1. Regerate readme.md * Fix help tab iframe url with www (#37) * Fix help tab iframe URL for non-US locales * Fix help tab iframe URL for non-US locales * Update readme with 1.4.2 changes * Bump tested up to to 5.2 * Remove $ reference and fix SVG icon (#39) * Remove $ reference and fix SVG icon * Remove console log from testing * Test plugin with WP 5.4 and minor style fix (#40) * Remove $ reference and fix SVG icon * Remove console log from testing * updated for 5.4 * tweak readme * revert version bump changes * fix json Co-authored-by: Evan Herman <evan.m.herman@gmail.com> Co-authored-by: Evan Herman <evanmherman@gmail.com> * Update readme for 1.4.3 release (#43) Co-authored-by: Frankie Jarrett <fjarrett@gmail.com> Co-authored-by: GoLF <loc-support@godaddy.com> Co-authored-by: Robert Sim <robertsky@users.noreply.github.com> Co-authored-by: Jonathan Bardo <bardo.jonathan@gmail.com> Co-authored-by: beebeatle <ab2009ukr@gmail.com> Co-authored-by: Aaron D. Campbell <aaron@xavisys.com> Co-authored-by: Anthony Ledesma <30462574+AnthonyLedesma@users.noreply.github.com>
* Fix deploy task * Add npmrc * Update travis config * Support banners and youtube in readme, add video * Use hqdefault for video thumbnail * GoLF Automated checkin by kchien (2/21/2017 4:30:02 PM) * Update cssmin package ver * Fix makepot task * Update POT * Update mo * Bump tested up to 4.8 * Bump tested up to * Switch wp_nonce to _wpnonce. Fix failing check_admin_referer when action === 'refresh' * Update devDependencies * set dist: precise for 5.2 * set dist: precise for 5.2 * Temporarily disable PHP 5.2. See travis-ci/travis-ci#8072 * Update dev dependencies. Re-grunt * Update changelog with 1.2.1 changes * Change Text Domain to Match WordPress.org Plugin Slug (#26) * update text domain for interested translators on translation.wordpress.org to work on plugin strings. * change text domain to match plugin slug in comments * fixing according to travis ci warnings only the i18n warnings. * more fixes based on travis ci output * fixing other warnings * one more warning * renamed language files to match text domain https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/#loading-text-domain * Add GDPR Support (#28) * Add support for GDPR fields. * Update gruntfile and npm dependencies * Add comment for tos_link * Resolve PHPCS warnings. Update phpcs.ruleset.xml. * Remove test filter * Add xmllint addon to travis build config * Double check for method before calling it. Update checkbox field value to match disply text. * Update gem-form-fields test to asset invalid_field_type returns empty. * Readd vendor dir to PHPCS exclusion * Add test for tos_link * Add test for tracking_option * Remove chrome from travis addons * Remove print * Add spacing for phpcs warnings * Add required checkboxes to error checking * Update update-pot grunt task. Regenerate translations after i18n function updates and updated i18n comments * Update read for 1.3.0 release * [dist] update packages * [dist] New package-lock * Introduce GEM Gutenberg block (#31) * Start to build out GEM gutenberg block * Save block output with proper shortcode * Add .babelrbs and webpack.config.js to .distignore * Resolve PHPCS warnings * Dynamically generate the GEM form in the GEM block * Bump tested up to version to 5.0 * Fix PHPCS spacing * Dynamic gem block * Update dynamic blocks * Add GEM block screenshots and update readme * Clean up UX during block addition/form selection. Cleanup JS file. * Add docblock to class prop * Update changelog, regenerate readme * Update GEM select field label * Update godaddy-email-marketing-sign-up-forms-ru_RU.po (#33) Added RU for several messages (Thank you for signing up, There was a problem). * Fix cache being bypassed when fetching forms (#34) * Regenerate mo files. Update changelog for 1.4.1. Regerate readme.md * Fix help tab iframe url with www (#37) * Fix help tab iframe URL for non-US locales * Fix help tab iframe URL for non-US locales * Update readme with 1.4.2 changes * Bump tested up to to 5.2 * Remove $ reference and fix SVG icon (#39) * Remove $ reference and fix SVG icon * Remove console log from testing * Test plugin with WP 5.4 and minor style fix (#40) * Remove $ reference and fix SVG icon * Remove console log from testing * updated for 5.4 * tweak readme * revert version bump changes * fix json Co-authored-by: Evan Herman <evan.m.herman@gmail.com> Co-authored-by: Evan Herman <evanmherman@gmail.com> * Update readme for 1.4.3 release (#43) * remove grunt-dev-update dependency (#46) * Add PHP linting (#47) * Adding php linting * automated fixes * fix all phpcs errors * phpcs fixes Co-authored-by: AnthonyLedesma <anthonymledesma@gmail.com> * Bump tested up to 5.7 (#65) * Bump tested up to 5.7 * Bump dealerdirect/phpcodesniffer-composer-installer Co-authored-by: Frankie Jarrett <fjarrett@gmail.com> Co-authored-by: GoLF <loc-support@godaddy.com> Co-authored-by: Robert Sim <robertsky@users.noreply.github.com> Co-authored-by: Evan Herman <evanmherman@gmail.com> Co-authored-by: Jonathan Bardo <bardo.jonathan@gmail.com> Co-authored-by: beebeatle <ab2009ukr@gmail.com> Co-authored-by: Aaron D. Campbell <aaron@xavisys.com> Co-authored-by: Anthony Ledesma <30462574+AnthonyLedesma@users.noreply.github.com> Co-authored-by: JR Tashjian <jrtashjian@gmail.com> Co-authored-by: AnthonyLedesma <anthonymledesma@gmail.com>
- Terms of Service Link (new method
tos_link
)- Tracking Option [checkbox]
- Age Verification [checkbox]
watch:js
taskWith the new field types introduced in GEM (
tos_link
,tracking_option
, andage_check
), these were not rendering when added to a signup form. Since the$field->field_type
wasn't defined as a method. (https://github.com/godaddy/wp-godaddy-email-marketing/blob/develop/includes/render.php#L119)This caused warnings to be thrown on front of site.
age_check
andtracking_option
will referenceRender::checkbox()
and a new functionRender::tos_link()
was introduced.Additional checks put in place so that if the field type does not exist as a method to call, we return early to prevent warnings on front of site.
New Fields
User Opt-in to Tracking
User Opt-out of Tracking