Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Changes to navigation #12

Closed
tobeycodes opened this issue Jul 3, 2016 · 3 comments
Closed

Changes to navigation #12

tobeycodes opened this issue Jul 3, 2016 · 3 comments

Comments

@tobeycodes
Copy link
Contributor

There are a few issues with the navigation

  1. It uses min-width and max-width. Ideally it should only use one and since the rest of the site is mobile first lets only use min-width. If we need to both, then it should be limited to only structural changes (floats, displays) but these things can still be achieved with only min-width
  2. The javascript on the mobile menu does not work
@tobeycodes
Copy link
Contributor Author

Now I made it so the site-title isn't forced to take up the entire header. We should strip back the navigation too. We could then more easily move the navigation from below the header region to inside it.

39e0b54

@tobeycodes
Copy link
Contributor Author

I've just pushed up a rewrite of the navigation (596859f)

  1. The menu-toggle can now be outside of the site-navigation container
  2. Show grand children on mobile with additional padding (hidden before)
  3. Only mobile first with a breakpoint at 600px (as before)
  4. The menu is no longer forced to take up the entire container, so easy to use multiple menus

If we want to introduce clickable dropdowns for children on mobile we will need to add a <span> in each element with the arrow since you before/after is not part of the DOM.

Pretty happy about this part, it was bugging me before how hard the SCSS was to change.

@fjarrett @chriswallace please review

@frankiejarrett
Copy link
Member

I'm happy with this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants