-
Notifications
You must be signed in to change notification settings - Fork 36
Clean up SCSS / HTML #9
Comments
I think it makes more sense if someone else at Lift works on these changes as my knowledge of this framework is limited to only working on the ascension theme but there are a lot of things that have definitely slowed down development |
Just a note that our min requirement is IE8 |
@fjarrett Ok. I've removed the suggestion to use flexbox, maybe it's a little early :) Susy or Bourbon Neat both will work on IE8 with https://github.com/keithclark/selectivizr |
@chriswallace I would consider this a priority going forward, since all the other child themes will need to be fixed for the same reasons. It's blocking things like #11 because the typography.scss imports the global mixins that has all the variables repeated which somehow causes a bug for the editor to automatically grow in height with each return. |
@chriswallace These changes to the scss broke some things. Here's what I've noticed
|
I'm really not happy with the current SCSS implementation. The more I dig, the deeper into the rabbit hole I go. |
@fjarrett there aren't really any things I like about it either. It's actually slowed down development a lot because it's written so badly. I'd rather scrap it entirely but it's not a quick fix |
It's making me nervous doing all this child theme work on top of this spaghetti parent SCSS.... |
Which is kinda why I gave up using it... My plan was to port this backwards afterwards. It's very much a WIP, so it's a little messy. But you can litterally build a child theme in a 1/10th of the time if you don't waste time on the parent SCSS crap |
One thing that gets to me the most is the html structure .xyz-class > .xyz-wrapper > .xyz-wrapper-inner There is no need to define a unique wrapper and inner for each block. You just need a single container class that can be used anywhere |
There is a lot of excess code in this parent theme that doesn't make much sense to me.
_typography
and_variables
. It's not clear which ones take priority_mixins
but a lot of mixins are not actually in the fileThe text was updated successfully, but these errors were encountered: