Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Susy refactor #35

Merged
merged 41 commits into from
Aug 1, 2016
Merged

Susy refactor #35

merged 41 commits into from
Aug 1, 2016

Conversation

frankiejarrett
Copy link
Contributor

@frankiejarrett frankiejarrett commented Jul 26, 2016

This PR is currently experimental and a continual WIP.

Goals:

@tobeycodes
Copy link
Contributor

tobeycodes commented Jul 26, 2016 via email

@frankiejarrett
Copy link
Contributor Author

@schrapel In a perfect world you are totally right, every child theme would follow the exact same Sass structure, using the same variables and Susy for grids, but I'm afraid we are to far along in the process now unfortunately for that kind of outcome without impacting the timeline - which is the highest priority.

The child themes don't load the parent styles at all, right? If this is true then I suggest we not change the markup in Primer at all and only address the Sass woes here and child themes can do their own thing for now.

If we nail the Primer styles exactly the way we want, then we will have a standard pattern by which child themes built in the future can use. Then down the road, we can start refactoring each of these first 9 child themes to go back and do what you're suggesting.

@tobeycodes
Copy link
Contributor

Yeah, they use a copy and pasted version of the css from primer at the time development started on the child theme. Not exactly sure why this format was chosen and I'm sure you noticed we've fixed things in certain child themes and then we have to also go and fix them all in the other themes too. It's a bit of a mess.

@frankiejarrett frankiejarrett self-assigned this Jul 27, 2016
@frankiejarrett
Copy link
Contributor Author

frankiejarrett commented Jul 28, 2016

@jonathanbardo @schrapel OK I think I've got this branch at a point where I could really use some review from you guys. As of right now the style.css size is cut by more than half. If there is anything that can be improved please do it, just don't over-do it as we want this to be as simple as possible.

Especially want input on the Sass file/folder/variable structure - I have very little experience or opinion on this, just want it to be as clear and easy to understand as possible.

@frankiejarrett
Copy link
Contributor Author

Don't forget to run npm install since I've added Susy to package.json.

@tobeycodes
Copy link
Contributor

Will have a look at this later tonight / tomorrow

@frankiejarrett frankiejarrett merged commit 03248e1 into develop Aug 1, 2016
@frankiejarrett frankiejarrett deleted the susy branch August 1, 2016 16:27
@frankiejarrett frankiejarrett restored the susy branch August 1, 2016 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants