First pass at custom layouts #26
Conversation
|
@jonathanbardo and @schrapel please review what I have here so far. |
|
Looks good. Will run some texts The UX is a lot better, clearly makes sense to users P.s go to bed, it must be late haha |
| .find( 'input' ) | ||
| .prop( 'disabled', false ); | ||
|
|
||
| } else { |
| @@ -162,7 +180,7 @@ module.exports = function(grunt) { | |||
|
|
|||
| require('matchdep').filterDev('grunt-*').forEach( grunt.loadNpmTasks ); | |||
|
|
|||
| grunt.registerTask('default', ['watch']); | |||
| grunt.registerTask('default', ['sass','autoprefixer','cssjanus','cssmin','jshint','uglify']); | |||
There was a problem hiding this comment.
@fjarrett @schrapel I've changed the default grunt command to only compile and run lint (this is what we used as default for out other plugins out there. grunt watch if you want to start watching all those files.
|
|
||
| } | ||
|
|
||
| $GLOBALS['primer_customizer_layouts'] = new Primer_Customizer_Layouts; |
There was a problem hiding this comment.
@jonathanbardo Just to give a little background on why I chose to assign the class to a global var. Layouts are a special case where helper functions in the global scope need to be available for theme developers when creating Child themes. The object itself if pretty lightweight and I believe this approach is better than instantiating a new object every time you want to call a helper method.
|
@jonathanbardo I'm pretty happy with this now after your changes. I'm going to merge this as-is and work on showing image thumbnails in the Customizer as a separate issue. |
Resolves #22