Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-in support for locale file endpoint #237

Closed
kquerna opened this issue Jan 4, 2021 · 0 comments · Fixed by #242
Closed

Opt-in support for locale file endpoint #237

kquerna opened this issue Jan 4, 2021 · 0 comments · Fixed by #242
Labels
enhancement New feature or request
Milestone

Comments

@kquerna
Copy link
Contributor

kquerna commented Jan 4, 2021

Description

We should have opt-in support for serving static locale files with server layer (express, fastify)? It maybe we helpful for existing apps to migrate to using the public dir with NextJS.

This option could be called serveStatic. If it is true in the config, set the endpoint to the defaultPath. We might also want allow the option to be set to a string and use that as the static endpoint. (i.e. serveStatic: '/locales'). This would be helpful if an app's default locale happens to differ from the static path.

Package(s): @gasket/plugin-intl

AC:

  • Ability to configure Gasket apps with endpoint for serving static locale files
  • Ability for existing apps to migrate to v6 without moving locale files
@kquerna kquerna added the enhancement New feature or request label Jan 4, 2021
@kquerna kquerna added this to the v6.0 milestone Jan 4, 2021
@kquerna kquerna linked a pull request Jan 12, 2021 that will close this issue
@kquerna kquerna closed this as completed Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant