Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for all CRD names #216

Closed
silasbw opened this issue Mar 9, 2018 · 2 comments
Closed

Add support for all CRD names #216

silasbw opened this issue Mar 9, 2018 · 2 comments

Comments

@silasbw
Copy link
Contributor

silasbw commented Mar 9, 2018

The current swagger client supports only the plural name for CRDs. Extend the client to support singular and shortNames too. Using example/using-crds.js and example/crontabs-crd.json:

// Plural usage, currently supported
await client.apis['stable.example.com'].v1.namespaces('default').crontabs.get();
// Singular (needs support)
await client.apis['stable.example.com'].v1.namespaces('default').crontab.get();
// shortNames (needs support)
await client.apis['stable.example.com'].v1.namespaces('default').ct.get();

See https://github.com/godaddy/kubernetes-client/blob/master/lib/swagger-client.js and https://kubernetes.io/docs/concepts/api-extension/custom-resources/ for more information.

@VaibhavPage
Copy link
Contributor

I can take a stab at it.

@silasbw
Copy link
Contributor Author

silasbw commented Jun 8, 2018

That would be great 🌶️ !

@silasbw silasbw closed this as completed May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants