Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CRDs): add Cluster scope support #307

Merged
merged 2 commits into from
Aug 7, 2018
Merged

feat(CRDs): add Cluster scope support #307

merged 2 commits into from
Aug 7, 2018

Conversation

popomore
Copy link
Contributor

@popomore popomore commented Aug 6, 2018

Ref #215

@popomore
Copy link
Contributor Author

popomore commented Aug 7, 2018

https://travis-ci.org/godaddy/kubernetes-client/jobs/412672463

It seems travis make the test failed.

@popomore
Copy link
Contributor Author

popomore commented Aug 7, 2018

@silasbw This feature is required by us, can you review and publish a new version?

@silasbw
Copy link
Contributor

silasbw commented Aug 7, 2018

Looking!

silasbw
silasbw approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@silasbw silasbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rad, thanks! 🌶️

@silasbw silasbw merged commit cb9f7e4 into godaddy:master Aug 7, 2018
@silasbw
Copy link
Contributor

silasbw commented Aug 7, 2018

I just published kubernetes-client@5.4.0 which includes this.

@popomore popomore deleted the crd-scope-cluster branch August 11, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silasbw silasbw silasbw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popomore @silasbw