fix(kube-config): use KUBECONFIG env var if set #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JacopoDaeli It shouldn't be more than a deep merge right once converting to JSON? Seems reasonable to support it. Doesn't have to be this PR though |
|
Yeah I agree with it. I am happy to work on a separate PR to support it. |
jcrugzz
approved these changes
Sep 5, 2018
|
Should we go straight to supporting the merge? What do we get by supporting the first kubeconfig file in the path? That seems like it's an unexpected thing to support. |
|
I think "having one single |
|
OK, sounds good to me. |
silasbw
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
Do we eventually want to support multiple config files in the future?
https://kubernetes.io/docs/tasks/access-application-cluster/configure-access-multiple-clusters/#create-a-second-configuration-file