Skip to content

Commit

Permalink
Drop support for python 3.6 (#411)
Browse files Browse the repository at this point in the history
* drop support for python36

* remove language support classifier

* Merge with main

Don't put back in the cruft we just took out

* Clean up dependencies

Where we had complex dependencies that now are unnecessary, simplify
them. Regenerate poetry.lock to track the result.

* Address pylint caching alerts

This commit addresses pylint alarms for instances of unbounded
`@lru_cache` decorators:

* In one instance, we merely silence the alarm; there is no structural
  way to address the concern. We believe the typical use pattern will be
  creation of a single scanner object that persists for nearly the life
  of execution, and therefore pylint's concerns regarding persistence of
  `self` references in the cache is not well-founded.

* In the other instance, we convert the function to a static method --
  it never referenced `self` anyway.

Co-authored-by: dclayton <dclayton@godaddy.com>
Co-authored-by: Scott Bailey <scott.bailey@godaddy.com>
  • Loading branch information
3 people committed Dec 21, 2022
1 parent 81115e0 commit 43b6aed
Show file tree
Hide file tree
Showing 6 changed files with 504 additions and 575 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Expand Up @@ -22,7 +22,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: [3.6, 3.7, 3.8, 3.9, "3.10"]
python-version: [3.7, 3.8, 3.9, "3.10"]
include:
- os: ubuntu-latest
path: ~/.cache/pypoetry
Expand All @@ -39,7 +39,6 @@ jobs:
name: Checkout the repo
- uses: actions/cache@c64c572235d810460d0d6876e9c705ad5002b353
name: Cache Poetry & Tox deps
if: ${{ !(matrix.os == 'windows-latest' && matrix.python-version == '3.6') }}
with:
path: |
{{ matrix.path }}
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
@@ -1,3 +1,9 @@
vX.X.X - DD MMM YYYY
--------------------

Features:
* [TBD](https://github.com/godaddy/tartufo/pull/401) - Drop python 3.6 support

v3.3.1 - 23 Nov 2022
--------------------

Expand Down

0 comments on commit 43b6aed

Please sign in to comment.