Drop support for python 3.6 #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't put back in the cruft we just took out
Where we had complex dependencies that now are unnecessary, simplify them. Regenerate poetry.lock to track the result.
This commit addresses pylint alarms for instances of unbounded `@lru_cache` decorators: * In one instance, we merely silence the alarm; there is no structural way to address the concern. We believe the typical use pattern will be creation of a single scanner object that persists for nearly the life of execution, and therefore pylint's concerns regarding persistence of `self` references in the cache is not well-founded. * In the other instance, we convert the function to a static method -- it never referenced `self` anyway.
sushantmimani
approved these changes
Dec 15, 2022
emayuri-godaddy
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
What's new?
This is a rework/resubmission of @dclayton-godaddy's #400 rebased on top of 3.3.1