Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report output on clean or successful scan #42

Closed
tcostello-godaddy opened this issue Feb 21, 2020 · 2 comments · Fixed by #157
Closed

Report output on clean or successful scan #42

tcostello-godaddy opened this issue Feb 21, 2020 · 2 comments · Fixed by #157
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@tcostello-godaddy
Copy link

tcostello-godaddy commented Feb 21, 2020

Feature Request

Need output to screen and or text file when scan results are clean.

Example:
scan run: 02-20-2020
scan result: 100% Clean. Success

or

'02/20/2020 - 100% Clean'

Is your feature request related to a problem? Please describe.

If scan is clear, command line returns nothing. Safe to assume the scan was clean....but would like CLI feedback.

Describe the solution you'd like

CLI returns when no errors/issues:

'date:time- 100% Clean'

Describe alternatives you've considered

Teachability, Documentation, Adoption, Migration Strategy

@tcostello-godaddy tcostello-godaddy added the enhancement New feature or request label Feb 21, 2020
@tarkatronic tarkatronic added the good first issue Good for newcomers label Feb 24, 2020
@tarkatronic
Copy link
Contributor

I think this makes sense. By default, we can print out some kind of success message.
All clear. No secrets detected.
We can also add a -q/--quiet flag to suppress that ouput.

This also goes hand in hand with #11 and #37. I think we need generally just a revamp of our outputs.

@janerikcarlsen
Copy link
Contributor

janerikcarlsen commented Dec 8, 2020

Taking this on together with #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants