Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The input_ray_pickable property is always true #336

Closed
mihe opened this issue May 16, 2023 · 0 comments · Fixed by #481
Closed

The input_ray_pickable property is always true #336

mihe opened this issue May 16, 2023 · 0 comments · Fixed by #481
Labels
bug Something that isn't working as intended external Involving an external party severity:minor Small impact on functionality or usability topic:runtime Concerning runtime behavior (or its source code)

Comments

@mihe
Copy link
Contributor

mihe commented May 16, 2023 •
edited

Originated from #92, #93, #94, #95 and #160.

The input_ray_pickable property on CollisionObject3D is currently always treated as true, because _intersect_ray is missing the pick_ray parameter that's needed to differentiate between a pick ray and a non-pick ray. This means we have to err on the side of assuming that every ray is not a pick ray and ignore the input_ray_pickable property entirely.

I made a pull request (godotengine/godot#74242) to fix this that's been merged into Godot 4.1, so this should be resolved fairly soon.
@mihe mihe added bug Something that isn't working as intended topic:runtime Concerning runtime behavior (or its source code) external Involving an external party labels May 16, 2023
@mihe mihe added the severity:minor Small impact on functionality or usability label May 23, 2023
@mihe mihe changed the title Changing the input_ray_pickable property makes no difference The input_ray_pickable property is always true Jun 3, 2023
@mihe mihe mentioned this issue Jul 6, 2023
Merged
@mihe mihe closed this as completed in #481 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that isn't working as intended external Involving an external party severity:minor Small impact on functionality or usability topic:runtime Concerning runtime behavior (or its source code)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated godot-cpp to 4.1 mihe/godot-jolt
1 participant
@mihe