Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands in the WASM guide should use pinned versions of rustc and emsdk #88

Closed
chitoyuu opened this issue Jan 24, 2023 · 1 comment · Fixed by #89
Closed

Commands in the WASM guide should use pinned versions of rustc and emsdk #88

chitoyuu opened this issue Jan 24, 2023 · 1 comment · Fixed by #89
Labels
error There is an error in the book in some way

Comments

@chitoyuu
Copy link
Contributor

chitoyuu commented Jan 24, 2023

It appears that the versions of LLVM used in rustc and emscripten have drifted out of sync again. Although the guide does specify a pair of known good versions of the tools, the commands simply use nightly and tot instead, and as a result some linking issues may arise when commands are blindly copied.

There are several steps we can take here. Firstly, the commands should be modified to use pinned versions. Longer term, we should see if there's a consistent way to tell the compatible version of emscripten from any given rustc version, or if we have to stick to manually finding known good pairs for the foreseeable future.

We should also see if #87 is still viable and if it can be merged into the current guide.

@chitoyuu chitoyuu added the error There is an error in the book in some way label Jan 24, 2023
@chitoyuu
Copy link
Contributor Author

User necrashter on Discord found a more recent pair of working toolchains:

rustc 1.69.0-nightly (ef982929c 2023-01-27) (currently latest nightly) and Emscripten 3.1.21 (f9e81472f1ce541eddece1d27c3632e148e9031a) combination also works

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error There is an error in the book in some way
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant