Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How different is this compared to the original facebookincubator repo? #29

Closed
Apidcloud opened this issue Jan 20, 2023 · 9 comments
Closed
Labels
question Further information is requested

Comments

@Apidcloud
Copy link

Apidcloud commented Jan 20, 2023

Hello!

Not sure if this is the place to ask such question, so feel free to point me in the right direction here.

I recently started using this repo, after finding it was a more up-to-date version of the original facebookincubator fbx2gltf repo. But now I'm wondering if the notes in the original README about certain improvements and not supported features are already taken into consideration in this fork. I'm asking because the README from this fork doesn't have all the info the original had.

In essence, I would like to know what's not supported when converting from fbx to gltf using the latest release (v0.13.0-p1). Do you happen to have a list or some info on it?

Thank you for your time and your awesome work!

@fire
Copy link
Member

fire commented Jan 20, 2023

The short answer is it has been several years since we diverged.

I don't remember all the changes. One would have to go through the last Facebook changes and patch by patch check.

If you have specific inquires I can try to find out.

@Calinou Calinou added the question Further information is requested label Jan 20, 2023
@akien-mga
Copy link
Member

I don't remember all the changes. One would have to go through the last Facebook changes and patch by patch check.

There's no change in the Facebook version that would be missing here. The upstream development stopped around the time you forked it.

The only FB commit which isn't in this fork is just removing the AppVeyor config: facebookincubator/FBX2glTF@739ee5d

@Apidcloud
Copy link
Author

Apidcloud commented Jan 21, 2023 via email

@fire
Copy link
Member

fire commented Jan 21, 2023

We defaulted to bake30fps. We attempted to solve pivots in gltf but it failed, so that part in the same state as the parent repo. The default of non pbr is still the same I think.

@fire
Copy link
Member

fire commented Jan 21, 2023

The build system works. I converted the original build system to something that runs smoothly.

@Apidcloud
Copy link
Author

Apidcloud commented Jan 22, 2023 via email

@fire
Copy link
Member

fire commented Jan 22, 2023

We changed the default to 8 bone weights max and to png.

@fire
Copy link
Member

fire commented Jan 23, 2023

Let me know if you have further questions, if not I can close whenever I remember to (a few days).

@Apidcloud
Copy link
Author

Thanks again! I'll reopen if meanwhile we have some specific question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants