Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for eglot ？ #121

Closed
xiliuya opened this issue Apr 16, 2023 · 1 comment · Fixed by #122
Closed

add support for eglot ？ #121

xiliuya opened this issue Apr 16, 2023 · 1 comment · Fixed by #122

Comments

@xiliuya
Copy link
Collaborator

xiliuya commented Apr 16, 2023

The relevant discussion is in: bug#62795

To accommodate eglot, can we add functions to the package?

(defun gdscript-mode-find-lsp (interactive-p)
  (let (port)
    ;; search for the port in this order: $XDG_CONFIG_HOME, /etc,
/ /usr.
    ;; This uses some regexp extracted from your awk expression.
    (ignore port 'todo)
    ;; then return the host-port list when found
    (and port (list "localhost" port))))
@RuijieYu
Copy link
Contributor

Note that João proposed an alternate name in a different subthread: gdscript-eglot-contact.

RuijieYu added a commit to RuijieYu/emacs-gdscript-mode that referenced this issue Apr 17, 2023
@RuijieYu
Added integration with eglot
cbca10b 
Fixes godotengine#121.

* gdscript-eglot.el gdscript-eglot-version: added customizable option for
the godot version in use.
(gdscript-eglot-contact): added function to allow `eglot' to find the godot LSP
port.
@RuijieYu RuijieYu mentioned this issue Apr 17, 2023
Merged
RuijieYu added a commit to RuijieYu/emacs-gdscript-mode that referenced this issue Apr 17, 2023
@RuijieYu
Added integration with eglot
d3e75a0 
Fixes godotengine#121.

* gdscript-eglot.el gdscript-eglot-version: added customizable option for
the godot version in use.
(gdscript-eglot-contact): added function to allow `eglot' to find the godot LSP
port.
* gdscript-mode.el Commmentary: double space after period.
(require 'gdscript-eglot): require this new file.
(with-eval-after-load 'eglot): tell eglot how to find godot LSP.
RuijieYu added a commit to RuijieYu/emacs-gdscript-mode that referenced this issue Apr 20, 2023
@RuijieYu
Added integration with eglot
82eb7d9 
Fixes godotengine#121.

* gdscript-eglot.el gdscript-eglot-version: added customizable option for
the godot version in use.
(gdscript-eglot-contact): added function to allow `eglot' to find the godot LSP
port.
* gdscript-mode.el Commmentary: double space after period.
(require 'gdscript-eglot): require this new file.
(with-eval-after-load 'eglot): tell eglot how to find godot LSP.
RuijieYu added a commit to RuijieYu/emacs-gdscript-mode that referenced this issue Apr 20, 2023
@RuijieYu
Added integration with eglot
397a4ba 
Fixes godotengine#121.

* gdscript-eglot.el gdscript-eglot-version: added customizable option for
the godot version in use.
(gdscript-eglot-contact): added function to allow `eglot' to find the godot LSP
port.
* gdscript-mode.el Commmentary: double space after period.
(require 'gdscript-eglot): require this new file.
(with-eval-after-load 'eglot): tell eglot how to find godot LSP.
NathanLovato pushed a commit that referenced this issue Apr 21, 2023
@RuijieYu
Added integration with eglot (#122)
30c4d48 
Fixes #121.

* gdscript-eglot.el gdscript-eglot-version: added customizable option for
the godot version in use.
(gdscript-eglot-contact): added function to allow `eglot' to find the godot LSP
port.
* gdscript-mode.el Commmentary: double space after period.
(require 'gdscript-eglot): require this new file.
(with-eval-after-load 'eglot): tell eglot how to find godot LSP.
drcxd pushed a commit to drcxd/emacs-gdscript-mode that referenced this issue Feb 27, 2024
@RuijieYu @drcxd
Added integration with eglot (godotengine#122)
4039d73 
Fixes godotengine#121.

* gdscript-eglot.el gdscript-eglot-version: added customizable option for
the godot version in use.
(gdscript-eglot-contact): added function to allow `eglot' to find the godot LSP
port.
* gdscript-mode.el Commmentary: double space after period.
(require 'gdscript-eglot): require this new file.
(with-eval-after-load 'eglot): tell eglot how to find godot LSP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added integration with eglot RuijieYu/emacs-gdscript-mode
2 participants
@RuijieYu @xiliuya