Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add convex hull 3d benchmark #51

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

franciscod
Copy link
Contributor

No description provided.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

For reference, I get these results on a release build with an i9-13900K:

image

Is it expected that there's little difference between any of these tests in terms of runtime?

@franciscod
Copy link
Contributor Author

franciscod commented Jan 22, 2024

I got some more variance on an older laptop -- around 2000ms for the quickest and 3500 for the more complex. Maybe it would make sense to tweak the benchmark parameters a bit? I'm not very familiar with the convex hull algorithm used here and its performance characteristics.

@franciscod
Copy link
Contributor Author

Results on a Mac Mini (M2):

image

Godot Engine v4.2.1.stable.mono.official.b09f793f5

@franciscod
Copy link
Contributor Author

And here are the results from the laptop on which I originally calibrated the benchmark:

"system":{"cpu_architecture":"x86_64","cpu_count":4,
"cpu_name":"Intel(R) Core(TM) i5-6200U CPU @ 2.30GHz",
"gpu_name":"Intel(R) HD Graphics 520 (SKL GT2)","gpu_vendor":"Intel","os":"Linux"}

AC plugged in (performance mode):
image

Battery (power saving mode):
image

(also Godot Engine v4.2.1.stable.mono.official.b09f793f5)

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with these benchmarks for now and see if they need to be improved if there's lots of variance on the benchmarks server.

Thanks!

@Calinou Calinou merged commit f509e14 into godotengine:main Feb 1, 2024
@franciscod franciscod deleted the convex branch February 1, 2024 17:08
@franciscod
Copy link
Contributor Author

franciscod commented Feb 1, 2024

I just noticed that these benchmarks weren't working. Follow-up PR soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants