Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect memory allocation in release builds. #1053

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix incorrect memory allocation in release builds. #1053

merged 1 commit into from
Feb 21, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Feb 21, 2023

Fixes #842

@bruvzg bruvzg added bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation labels Feb 21, 2023
@bruvzg bruvzg added this to the 4.0 milestone Feb 21, 2023
@bruvzg bruvzg force-pushed the fix_release_memalloc branch 3 times, most recently from ff2d220 to a18b20f Compare February 21, 2023 12:15
@bruvzg bruvzg marked this pull request as ready for review February 21, 2023 12:17
@bruvzg bruvzg requested a review from a team as a code owner February 21, 2023 12:17
@bruvzg @lightyears1998
Fix incorrect memory allocation in release builds.
ba4b501 
Co-authored-by: lightyears <lightyears1998@hotmail.com>
@bruvzg bruvzg requested a review from a team as a code owner February 21, 2023 13:32
@bruvzg
Copy link
Member Author

bruvzg commented Feb 21, 2023

The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002

Seems like CI config need an update. Changed it to 20.04

@akien-mga akien-mga merged commit 2a15286 into godotengine:master Feb 21, 2023
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the fix_release_memalloc branch February 21, 2023 13:52
@Faless Faless mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Possible heap corruption issue
2 participants
@bruvzg @akien-mga