Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_valid_ip_address - unclear #4097

Closed
CitrusWire opened this issue Sep 30, 2020 · 0 comments · Fixed by godotengine/godot#42435
Closed

is_valid_ip_address - unclear #4097

CitrusWire opened this issue Sep 30, 2020 · 0 comments · Fixed by godotengine/godot#42435
Labels
area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository enhancement

Comments

@CitrusWire
Copy link

Your Godot version:
n/a

Issue description:

bool is_valid_ip_address ( )

Returns true if this string contains a valid IP address.

Isn't clear for a number of reasons:

URL to the documentation page (if already existing):
https://docs.godotengine.org/en/latest/classes/class_string.html
@Calinou Calinou added the area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository label Sep 30, 2020
@Calinou Calinou mentioned this issue Sep 30, 2020
Merged
Calinou added a commit to Calinou/godot that referenced this issue Sep 30, 2020
@Calinou
Improve the String.is_valid_ip_address() documentation
00ade39 
This closes godotengine/godot-docs#4097.
akien-mga pushed a commit to akien-mga/godot that referenced this issue Oct 1, 2020
@Calinou @akien-mga
Improve the String.is_valid_ip_address() documentation
016ea49 
This closes godotengine/godot-docs#4097.

(cherry picked from commit 00ade39)
MarcusElg pushed a commit to MarcusElg/godot that referenced this issue Oct 19, 2020
@Calinou @MarcusElg
Improve the String.is_valid_ip_address() documentation
0619d9e 
This closes godotengine/godot-docs#4097.
schme pushed a commit to schme/godot that referenced this issue Mar 29, 2021
@Calinou
Improve the String.is_valid_ip_address() documentation
7878545 
This closes godotengine/godot-docs#4097.

(cherry picked from commit 00ade39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the String.is_valid_ip_address() documentation Calinou/godot
2 participants
@Calinou @CitrusWire