Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curve3D's "interpolate_baked" function description states that "offset is measured as a pixel distance" #4339

Closed
Arnklit opened this issue Nov 5, 2020 · 0 comments · Fixed by godotengine/godot#44012
Closed

Curve3D's "interpolate_baked" function description states that "offset is measured as a pixel distance" #4339

Arnklit opened this issue Nov 5, 2020 · 0 comments · Fixed by godotengine/godot#44012
Labels
area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository bug

Comments

@Arnklit
Copy link
Contributor

Arnklit commented Nov 5, 2020

Your Godot version:
3.2.3.Stable

Issue description:
Curve3D's "interpolate_baked" function description states that "offset is measured as a pixel distance".
I'm pretty sure that's incorrect and it should say that it's a distance in 3D space like the interpolate_baked_up_vector function does.

image

URL to the documentation page:
https://docs.godotengine.org/en/stable/classes/class_curve3d.html#method-descriptions
@Arnklit Arnklit added the bug label Nov 5, 2020
@NathanLovato NathanLovato added the area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository label Nov 5, 2020
This was referenced Dec 1, 2020
Closed
Merged
Calinou added a commit to Calinou/godot that referenced this issue Dec 1, 2020
@Calinou
Fix incorrect Curve3D.interpolate_baked() description
5a9600c 
The offset is in 3D units, not pixels.

This closes godotengine/godot-docs#4339.
akien-mga pushed a commit to akien-mga/godot that referenced this issue Dec 2, 2020
@Calinou @akien-mga
Fix incorrect Curve3D.interpolate_baked() description
eda04c6 
The offset is in 3D units, not pixels.

This closes godotengine/godot-docs#4339.

(cherry picked from commit 5a9600c)
HEAVYPOLY pushed a commit to HEAVYPOLY/godot that referenced this issue Dec 14, 2020
@Calinou @HEAVYPOLY
Fix incorrect Curve3D.interpolate_baked() description
1d8f48b 
The offset is in 3D units, not pixels.

This closes godotengine/godot-docs#4339.

(cherry picked from commit 5a9600c)
schme pushed a commit to schme/godot that referenced this issue Mar 29, 2021
@Calinou
Fix incorrect Curve3D.interpolate_baked() description
506e4c8 
The offset is in 3D units, not pixels.

This closes godotengine/godot-docs#4339.

(cherry picked from commit 5a9600c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect Curve3D.interpolate_baked() description Calinou/godot
2 participants
@Arnklit @NathanLovato