Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable_file_logging.pc undocumented #4505

Closed
CitrusWire opened this issue Dec 30, 2020 · 0 comments · Fixed by godotengine/godot#44817
Closed

enable_file_logging.pc undocumented #4505

CitrusWire opened this issue Dec 30, 2020 · 0 comments · Fixed by godotengine/godot#44817
Labels
area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository enhancement

Comments

@CitrusWire
Copy link

Issue description:
enable_file_logging.pc doesn't have any doc line at all and the name doesn't hint at what it could be.
I assume this comment from main.cpp relates to it:

// Only file logging by default on desktop platforms as logs can't be
1131 // accessed easily on mobile/Web platforms (if at all).
1132 // This also prevents logs from being created for the editor instance, as feature tags
1133 // are disabled while in the editor (even if they should logically apply).
1134 GLOBAL_DEF("logging/file_logging/enable_file_logging.pc", true)

URL to the documentation page (if already existing):
https://docs.godotengine.org/en/stable/classes/class_projectsettings.html#class-projectsettings-property-logging-file-logging-enable-file-logging-pc
@Calinou Calinou mentioned this issue Dec 30, 2020
Merged
Calinou added a commit to Calinou/godot that referenced this issue Dec 30, 2020
@Calinou
Document the desktop-only file logging setting override
bd0b700 
This closes godotengine/godot-docs#4505.
@Calinou Calinou added the area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository label Dec 30, 2020
akien-mga pushed a commit to akien-mga/godot that referenced this issue Jan 5, 2021
@Calinou @akien-mga
Document the desktop-only file logging setting override
58efe5f 
This closes godotengine/godot-docs#4505.

(cherry picked from commit bd0b700)
schme pushed a commit to schme/godot that referenced this issue Mar 29, 2021
@Calinou
Document the desktop-only file logging setting override
02472ab 
This closes godotengine/godot-docs#4505.

(cherry picked from commit bd0b700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:class reference Issues and PRs about the class reference, which should be addressed on the Godot engine repository enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document the desktop-only file logging setting override Calinou/godot
2 participants
@Calinou @CitrusWire