[Minor] Fix "it's" that should be "its" #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
approved these changes
Jul 6, 2019
cbscribe
suggested changes
Jul 6, 2019
tutorials/shading/your_first_shader/your_second_spatial_shader.rst
Outdated
Show resolved
Hide resolved
tutorials/shading/your_first_shader/your_second_spatial_shader.rst
Outdated
Show resolved
Hide resolved
|
Files in |
|
Ok, thank you both! I think I have addressed your comments. |
|
Can you squash these into a single commit, please? |
|
Sure! Though if what you want is a single commit, GitHub has a button for that 😉 [edit: rebased as 2 commits: it's->its and other] |
The squash feature on git has some limitations. We can use it here from time to time as the docs' history isn't super important, but e.g. not on the Godot repo as you won't get a merge commit, among other things that make a difference. |
|
Thanks for the help! |
akien-mga
pushed a commit
to godotengine/godot
that referenced
this pull request
Jul 29, 2019
See also godotengine/godot-docs#2595 (cherry picked from commit ddfd674)
myhalibobo
pushed a commit
to myhalibobo/godot
that referenced
this pull request
Sep 3, 2019
fire
pushed a commit
to V-Sekai-archive/godot-csg-manifold
that referenced
this pull request
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw some "it's" that should have been "its", so I went over the whole doc. I actually found very few of those, so I guess I'm just overly pedant, but thought I'd send the patch anyway.
Cheers!