-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Minor] Fix "it's" that should be "its" #2595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - just a couple of other fixes needed as well.
tutorials/shading/your_first_shader/your_second_spatial_shader.rst
Outdated
Show resolved
Hide resolved
tutorials/shading/your_first_shader/your_second_spatial_shader.rst
Outdated
Show resolved
Hide resolved
Files in |
Ok, thank you both! I think I have addressed your comments. |
Can you squash these into a single commit, please? |
Sure! Though if what you want is a single commit, GitHub has a button for that 😉 [edit: rebased as 2 commits: it's->its and other] |
The squash feature on git has some limitations. We can use it here from time to time as the docs' history isn't super important, but e.g. not on the Godot repo as you won't get a merge commit, among other things that make a difference. |
Thanks for the help! |
See also godotengine/godot-docs#2595 (cherry picked from commit ddfd674)
I saw some "it's" that should have been "its", so I went over the whole doc. I actually found very few of those, so I guess I'm just overly pedant, but thought I'd send the patch anyway.
Cheers!