Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update files to Godot 4.x #107

Merged
merged 9 commits into from
Nov 9, 2023
Merged

Update files to Godot 4.x #107

merged 9 commits into from
Nov 9, 2023

Conversation

ParadoxV5
Copy link

Closes #106
#99 does not apply

@Calinou
Copy link
Member

Calinou commented May 19, 2023

Sorry for the delay in reviewing this PR. Now that Godot 4.0.3 is released, could you amend this PR to target 4.0.3?

@ParadoxV5
Copy link
Author

just received the news and got here at the same time you commented, Lol

@ParadoxV5 ParadoxV5 changed the title Update files to Godot 4.0.2-stable Update files to Godot 4.0.3-stable May 19, 2023
@akien-mga
Copy link
Member

akien-mga commented May 22, 2023

Actually, I wonder if we should just drop the master branch in this repository. It's useful for GDNative (3.x), but for GDExtension with only two files, having to keep a separate repo in sync seems overkill.

godot-cpp moved to including the two files directly so it doesn't have to rely on a nested submodule.
godot-python and godot-rust both download the relevant Godot binary to let it generate the version they need (godot --dump-extension-api --dump-gdextension-interface).

We might need to keep the master branch in this repo for compatibility with the Git history of some of those projects which used to use this repo as a submodule, but aside from this I don't know if it's worth keeping pushing new versions to it.

@ParadoxV5
Copy link
Author

ParadoxV5 commented May 22, 2023

Some folks may prefer a submodule workflow, and I’m interested too. It allows upgrading to be simply a submodule update instead of browsing the repo for the header and typing commands for the JSON.

but for GDExtension with only two files, having to keep a separate repo in sync seems overkill.

(Indeed, with only two files, I even considered flattening /godot/gdextension_interface.h right to the repo root.)

If the choice is to get users to fetch from the engine repo, I’d like both the header and API in the same place (e.g., /include/), preferably in a dedicated (sub)folder. Git submodule doesn’t seem to support submodule-ing a repo directory, but at least we’ll only have to download a specific folder and know which.

godot-cpp moved to including the two files directly so it doesn't have to rely on a nested submodule. godot-python and godot-rust both download the relevant Godot binary to let it generate the version they need (godot --dump-extension-api --dump-gdextension-interface).

Their reason may very well be because this header repo went outdated for a long while and thus is no longer reliable.

We might need to keep the master branch in this repo for compatibility with the Git history of some of those projects which used to use this repo as a submodule

Yep. Godot 3.6 will be LTS; it ain’t going anywhere soon. (P.S. see #106)

@ParadoxV5
Copy link
Author

Woke up to a great surprise today: Godot 4.1 video by GDQuest in my feed.

@ParadoxV5 ParadoxV5 changed the title Update files to Godot 4.0.3-stable Update files to Godot 4.1.0 Jul 6, 2023
@ParadoxV5 ParadoxV5 changed the title Update files to Godot 4.1.0 Update files to Godot 4.x Aug 4, 2023
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge to clarify the state of the current master branch, but as pointed out previously, I don't think we really need to keep maintaining this repository.

Both files can be generated by the Godot binary directly, which helps ensure that there's a correct sync between the extension API and the Godot binary that will use it.

@akien-mga akien-mga merged commit 5872d2a into godotengine:master Nov 9, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify status of this repo with respect to Godot 4
3 participants