Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced environ.get with os.getenv for Windows compatibility #1

Closed
wants to merge 2 commits into from

Conversation

BenMcLean
Copy link

No description provided.

@neikeq
Copy link
Contributor

neikeq commented Sep 18, 2019

Is there a problem with environ.get on Windows?

Also there's one more usage of environ.get:

ccache_path = environ.get('CCACHE', '')

@akien-mga
Copy link
Member

Is there a problem with environ.get on Windows?

Probably not, but if HOME is undefined, then environ.get("HOME") will be None which breaks the follow-up code. While getenv("HOME", "") gives a default fallback value if the env variable is undefined.

This PR needs to be rebased and squashed into one commit.

@neikeq
Copy link
Contributor

neikeq commented Apr 6, 2020

I wasn't thinking properly when I first commented. The scripts don't support Windows (unless it's cygwin or WSL).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants