Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve post-process color correction by supporting 3D LUTs instead of a single Gradient #1382

Closed
Darkinggq opened this issue Aug 17, 2020 · 8 comments
Milestone

Comments

@Darkinggq
Copy link

Darkinggq commented Aug 17, 2020

Describe the project you are working on:
Godot Editor, I will decide to work on ARPG 3D (low poly)

Describe the problem or limitation you are having in your project:
Godot need to improve post process (LUTs) for Color Grading very helpful

Area Post Process Box example hit inside color change other different colors

Describe the feature / enhancement and how it helps to overcome the problem or limitation:
description here
image

https://docs.unrealengine.com/en-US/Engine/Rendering/PostProcessEffects/UsingLUTs/index.html

example screenshot to the left or to the right the color is different depends on customize for the designer
image

Describe how your proposal will work, with code, pseudocode, mockups, and/or diagrams:
.......

If this enhancement will not be used often, can it be worked around with a few lines of script?:
.......

Is there a reason why this should be core and not an add-on in the asset library?:
Post Process is very useful for realistic graphic games, if without it it would be very bad, this is for 3D AAA studio games (of course the core)

@Calinou
Copy link
Member

Calinou commented Aug 17, 2020

See also #903.

@Calinou Calinou changed the title Add Post Process LUT and Area Post Process Box Improve post-process color correction by supporting 3D LUTs instead of a single Gradient Aug 17, 2020
@fire
Copy link
Member

fire commented Oct 13, 2020

This pull request can be updated for 4.0 if you're interested. godotengine/godot#26101

It's less hard than #903.

@Darkinggq
Copy link
Author

This pull request can be updated for 4.0 if you're interested. godotengine/godot#26101

yeah i'm see

@fire
Copy link
Member

fire commented Nov 11, 2020

I ran out of effort, but you can see my last pr. The vulkan render isn't showing the 3d lut.

godotengine/godot#42761

@fire
Copy link
Member

fire commented Nov 12, 2020

See updated pr.

@Darkinggq
Copy link
Author

checking now :)

@Jummit
Copy link

Jummit commented Feb 14, 2021

Isn't this added in godotengine/godot#42761?

@clayjohn
Copy link
Member

Isn't this added in godotengine/godot#42761?

Yep. Closing as it has been added. :)

@clayjohn clayjohn added this to the 4.0 milestone Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants