Color correction now uses a 3D texture.

[QbieShay]

Breaks games that use the existing color correction.

demo usage:
https://gfycat.com/mammothlivelyblacklab

Model from Desmond Man

[Calinou]

Looks good, this should make color correction more powerful 😃

Would it be possible to implement this in a way that still makes GradientTexture usable for color correction? Having to use an image editor for simple color grading sounds quite cumbersome to tweak. Perhaps there could be a 3D GradientTexture resource in a future version?

[QbieShay]

@CptPotato I implemented your change, but in order to co-author you I need your email :<

[CptPotato]

@QbieShay You can leave the commit as is if you'd like. I'd prefer to keep my mail address private.

Though, make sure to test the change as I haven't done that. It should be really obvious with a neutral 2³ or 3³ texture.

[QbieShay]

@CptPotato Will test this evening, thank you very much for the tip!

[fire]

@QbieShay Did you test?

[QbieShay]

@fire I did! Works!

[fire]

There was some difficulty converting a png lookup table to a 3d texture. I have to do 16 horizontal and 1 vertical. It would probably be better to support a .cube to 3d texture directly, but it works for me too!

[aaronfranke]

@QbieShay Is this still desired? If so, it needs to be rebased on the latest master branch, and reworked to support Vulkan.

If not, abandoned pull requests will be closed in the future as announced here.

[fire]

I still desire this. It required some engine investigation though.

[QbieShay]

Hi @aaronfranke ! I haven't looked into the Vulkan renderer yet. I'm sad that this PR didn't make it into 3.x, but I expected it due to compat problems. I'll close this PR and maybe open another one for Vulkan in the future!