Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance editor line length guide #347

Closed
Feniks-Gaming opened this issue Jan 2, 2020 · 2 comments · Fixed by godotengine/godot#36232
Closed

Enhance editor line length guide #347

Feniks-Gaming opened this issue Jan 2, 2020 · 2 comments · Fixed by godotengine/godot#36232
Milestone

Comments

@Feniks-Gaming
Copy link

Describe the project you are working on:

Breakout Clone

Describe the problem or limitation you are having in your project:

Currently Godot offers only one line guide that user can defined in settings by default set to 80 right now. This is great but sometimes it is beneficial to have more than one line guide many users will use something like soft limit and hard limit. Users will aim for majority of their code to don't extend over soft limit but will allow it at occasions. On the other hand the will never cross hard limit

Describe how this feature / enhancement will help you overcome this problem or limitation:

It's fairly simple but will improve usability of the editor

Show a mock up screenshots/video or a flow diagram explaining how your proposal will work:

Here is example how atom does it
1

Describe implementation detail for your proposal (in code), if possible:

I can imagine this as just replicating whatever code is used to create Line Length Guideline Column and giving it different value maybe allowing users to create more guildelines as they please?

If this enhancement will not be used often, can it be worked around with a few lines of script?:

It would can be worked around by simply visually seeing code being roughly the desired length but it's nice to have

Is there a reason why this should be core and not an add-on in the asset library?:

It's part of a main editor and fairly easy to do.

@Calinou
Copy link
Member

Calinou commented Jan 2, 2020

It makes sense to add a way to display 2 line length guidelines (soft + hard), but more than 2 guidelines sounds overkill to me.

@Feniks-Gaming
Copy link
Author

2 is enough I agree.

Calinou added a commit to Calinou/godot that referenced this issue Feb 15, 2020
The default value is 80. The hard line length guideline's
default column has been moved to 100 to account for the new
soft line length guideline.

It can be disabled by setting its value to the same column as the
hard line length guideline.

This closes godotengine/godot-proposals#347.
dankan1890 pushed a commit to dankan1890/godot that referenced this issue Feb 18, 2020
The default value is 80. The hard line length guideline's
default column has been moved to 100 to account for the new
soft line length guideline.

It can be disabled by setting its value to the same column as the
hard line length guideline.

This closes godotengine/godot-proposals#347.
WizardOhio24 pushed a commit to WizardOhio24/godot that referenced this issue Feb 27, 2020
The default value is 80. The hard line length guideline's
default column has been moved to 100 to account for the new
soft line length guideline.

It can be disabled by setting its value to the same column as the
hard line length guideline.

This closes godotengine/godot-proposals#347.
@mhilbrunner mhilbrunner added this to the 4.0 milestone Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants