Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial/Node2D locks should not be saved through metadata #13098

Open
kubecz3k opened this issue Nov 20, 2017 · 6 comments
Open

Spatial/Node2D locks should not be saved through metadata #13098

kubecz3k opened this issue Nov 20, 2017 · 6 comments

Comments

@kubecz3k
Copy link
Contributor

Operating system or device, Godot version, GPU Model and driver (if graphics related):
450bdda

Issue description:
According to discussion in #12359 it seems locks should not be saved inside scene metadata anymore. Instead there should be new bool property inside node2d/spatial that should not be visible in inspector. As far as we discussed on IRC this still could be considered for 3.0

@groud
Copy link
Member

groud commented Nov 21, 2017

I guess the "selectable children" metadata could be moved too :)

@akien-mga
Copy link
Member

We have now entered release freeze for Godot 3.0 and want to focus only on release critical issues for that milestone. Therefore, we're moving this issue to the 3.1 milestone, though a fix may be made available for a 3.0.x maintenance release after it has been tested in the master branch during 3.1 development. If you consider that this issue is critical enough to warrant blocking the 3.0 release until fixed, please comment so that we can assess it more in-depth.

@akien-mga akien-mga modified the milestones: 3.0, 3.1 Jan 5, 2018
@Piet-G
Copy link
Contributor

Piet-G commented Sep 23, 2018

After discussion with @groud he recommended this should get moved to 3.2.

@akien-mga akien-mga modified the milestones: 3.1, 3.2 Sep 23, 2018
@akien-mga akien-mga modified the milestones: 3.2, 4.0 Nov 14, 2019
@KoBeWi
Copy link
Member

KoBeWi commented Jan 3, 2020

I disagree. Metadata are perfect place to store editor-related info. They are all prefixed with _edit_, so it doesn't conflict with user's values.
I wonder if it's possible/viable to strip them on project export.

@akien-mga akien-mga modified the milestones: 4.0, 4.x Feb 23, 2023
@akien-mga
Copy link
Member

Is this still relevant as of 4.0? I know we moved a lot of stuff out of scenes and to editor-specific folders, might include this.

@KoBeWi
Copy link
Member

KoBeWi commented Feb 23, 2023

Some issues caused by metadata were fixed, so this is less relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants