Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_exists may not find all selected resources when exported #24065

Closed
IoriBranford opened this issue Nov 29, 2018 · 4 comments
Closed

file_exists may not find all selected resources when exported #24065

IoriBranford opened this issue Nov 29, 2018 · 4 comments
Milestone

Comments

@IoriBranford
Copy link

IoriBranford commented Nov 29, 2018

Godot version:

Godot 3.0.6

OS/device including version:

Observed on Linux, Windows, Android.

Issue description:

When the resource export mode is "selected resources", file_exists may not find some of the selected resources.

In the sample game, file_exists finds icon.png but not icon2.png. But icon2.png can be loaded anyway. Both their export settings are exactly the same.

Does not occur when run from the editor.

Steps to reproduce:

  1. Export the sample project to any of the desktop platforms.
  2. Run the export in a terminal to see the text output.

Minimal reproduction project:

bug-file_exists.zip

It could be related to #18740. But I couldn't find any obvious differences or problems in the conversions of the icons.

@volzhs
Copy link
Contributor

volzhs commented Nov 29, 2018

what about using ResourceLoader.exists(path) instead of Directory.file_exists?

@IoriBranford
Copy link
Author

IoriBranford commented Nov 29, 2018

Not until 3.1.0 comes out unfortunately.

@clayjohn
Copy link
Member

Is this reproducible in 3.1?

@KoBeWi
Copy link
Member

KoBeWi commented Aug 21, 2020

Fixed in 3.1 (or 3.2)

@KoBeWi KoBeWi closed this as completed Aug 21, 2020
@KoBeWi KoBeWi added this to the 3.1 milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants