Possible unused variables/functions in engine code (cppcheck report)

[Rubonnek]

Godot version:

master branch commit 52b7f26

Issue description:

Unusued functions and variables found by cppcheck. Many of these could be false-positives due to binding to Java, Mono, etc.

Steps to reproduce:

• cd $godot_repo_root
• cppcheck --enable=all --inconclusive --std=posix --force . 2> cppcheck_godot.log
• rg -A 1 "\[unu" cppcheck_godot.log > unused_thirdparty_unfiltered.txt
• And use the following Python 3 script to extract the possibly unused variables and functions:

#!/usr/bin/env python3

fh = open("unused_thirdparty_unfiltered.txt", "r")
mybuf = ""
count = 0
skip_lines = False
for line in fh:
    if line.startswith("thirdparty"):
        skip_lines = True
        continue

    if skip_lines:
        count += 1
        if count == 2:
            skip_lines = False
            count = 0
    else:
        if line != "\n":
            mybuf += line
print(mybuf,end="")

Minimal reproduction project:
unused.txt

[KoBeWi]

The list should be updated, because many of this can be potentially outdated now.

[Rubonnek]

List updated.

[qarmin]

It is possible to generate graphical cppcheck report with this command

cppcheck -j6  -ithirdparty -i3rdparty -itests -itest -itoolchain -itools  --enable=all --force --output-file=cppcheck.xml --xml --xml-version=2 .;cppcheck-htmlreport --source-dir=. --title=project --file=cppcheck.xml --report-dir=report;xdg-open report/index.html

Looks that unused functions require to remove -j6 from command(check can't work when checking parts of program in several threads)

Generated report for bd9799e - report.zip

Unread variables, redundant assignement, unusedStructMember, redundantInitialization and unused private function should be useful for this issue

This allow to click at report to see code with place where error exists

[KoBeWi]

Probably worth refreshing this. A big PR was recently merged and the codebase changed quite a lot too. I tried using cppcheck myself, but it just freezes around 12% :/

[Rubonnek]

Here's a report against commit 9f74f0f. Generated with cppcheck version 2.9.3.

I've also opened #71767 to track the same issue but on the 3.x branch and I've also attached a report.