Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui styles are shrinking edges of texture #35339

Open
Shadowblitz16 opened this issue Jan 19, 2020 · 4 comments
Open

Gui styles are shrinking edges of texture #35339

Shadowblitz16 opened this issue Jan 19, 2020 · 4 comments

Comments

@Shadowblitz16
Copy link

Godot version:
3.2 beta 4

OS/device including version:
Windows 10 pro education 64 bit

Issue description:
styles are shrinking edges of texture on buttons when they edges should not be modified at all.
here is a picture of the edges being half the size then they should be
image

image

what should be happening is that the edges do not shrink but instead the center does like 9 slices should.

Steps to reproduce:

  • make a 16x16 rectangle texture with 1 pixel wide edges in a photo editing program.
  • add a button and assign the texture to the default style with a margin of 1,1,1,1
  • resize it smaller then the texture size
  • see result

Minimal reproduction project:
9Slice Style Bug.zip

@dankan1890
Copy link
Contributor

It's a change made by #32170.

@Shadowblitz16
Copy link
Author

then it should either be reverted or enabled by a flag which is default to off because thats not how 9 slices are suppose to work.

@qq715152910
Copy link

then it should either be reverted or enabled by a flag which is default to off because thats not how 9 slices are suppose to work.
I had the same problem, but they ignored my existence ...
#37027

@CavemanIke
Copy link

CavemanIke commented Apr 16, 2020

The aforementioned change that was implemented really shouldn't have been done without some careful thought into what kind of workflows this may break. I've been building a GUI system for a simulation game and if I have windows that are resizable or if I create one that just happens to get close to the texture size it of course starts to distort. Now I'm having to employ workarounds such as defining minimum sizes and doing a lot of extra fine-tuning of the artwork and making adjustments to it, the code, layouts, etc. in order to accommodate this new behaviour. That is a lot of time I really wish I didn't have to put into this. I can definitely see where this kind of change may be useful, but it needs to be a toggle-able option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants