Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some settings don't use "Find file/directory" dialog #42453

Open
CitrusWire opened this issue Oct 1, 2020 · 1 comment
Open

Some settings don't use "Find file/directory" dialog #42453

CitrusWire opened this issue Oct 1, 2020 · 1 comment

Comments

@CitrusWire
Copy link

Godot version:
3.2.3 on Windows 7

Issue description:
There's some degree of inconsistency in the use of "Find file"/"Find Directory" helper dialog when setting settings for Project Settings. Many settings use these (good), but the following do not (bad):

Project settings -> General

  • Application/Config -> "Custom User Dir Name"
  • Application/Config -> "Project Settings Override"
  • Logging/FileLogging -> Log Path (This one is also wrongly named - it's a Log File, not a Log Path).

I believe that's all of the missing ones for the General Tab.

Project settings -> Plugins

  • Create -> "SubFolder" and possibly "Script Name".

The Editor Settings all seem to be fine.

@akien-mga
Copy link
Member

akien-mga commented Oct 1, 2020

Project settings -> General

  • Application/Config -> "Custom User Dir Name"
  • Application/Config -> "Project Settings Override"
  • Logging/FileLogging -> Log Path (This one is also wrongly named - it's a Log File, not a Log Path).

I think those are all fine as is. They're not folder or file paths (C:\Users\blabla\AppData\My Game) but folder or file names that will be appended automatically to the relevant system path (e.g. My Game for application/config/custom_user_dir_name).
You can't choose any path for this custom user dir, it will be placed in the system-specific folder dedicated to application data (%APPDATA% on Windows, XDG_DATA_HOME on Linux, etc.).

Same thing for Project Settings Override which should be the relative path of a file in the virtual user:// filesystem. The actual location on disk of user:// depends on the OS and the value of application/config/custom_user_dir_name, so it doesn't make sense to let you select it with a file dialog as this would be specific to your own OS and user session.

Same thing for the log file path, which is also relative to user://.

Project settings -> Plugins

  • Create -> "SubFolder" and possibly "Script Name".

This one can make sense yes. But note that currently it's the path of a folder which you ask the plugins creation dialog to create for you, to place a newly created script file in it with the given name. If you have to use a File Dialog to select the folder, then you have to create it yourself instead of letting this creation tool do it for you. Similarly, if you want to use a file dialog for the script name, you'd have to create the script beforehand. At this point you've already done half of the work that this plugin creation helper does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants