Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackBufferCopy GLES2 regression in v3.2.2 #43644

Closed
Zoomulator opened this issue Nov 18, 2020 · 5 comments
Closed

BackBufferCopy GLES2 regression in v3.2.2 #43644

Zoomulator opened this issue Nov 18, 2020 · 5 comments

Comments

@Zoomulator
Copy link

Zoomulator commented Nov 18, 2020

Godot version:
3.2.2
3.2.3

OS/device including version:
Windows 10
GLES2
NVidia GTX 1060 6GB

Issue description:
BackBufferCopy doesn't copy at the right moment when using Godot >= v3.2.2 with GLES2. This worked fine in v3.2.1 of Godot, so this is a regression.
Works fine with GLES3.

v3.2.1 with GLES2
bild

v3.2.2 and v3.2.3 with GLES2
bild

Steps to reproduce:

  • Create a 2D scene.
  • Add a sprite.
  • Add a BackBufferCopy.
  • Add another sprite overlapping the first.
  • Add a Mesh covering both sprites and set its shader to output COLOR = texture(SCREEN_TEXTURE, SCREEN_UV) * vec4(1,1,1,0.5);
  • The result should make the second sprite semi-transparent.

Minimal reproduction project:
BackBufferCopyGLES2.zip

@akien-mga
Copy link
Member

It's a regression from the new 2D batching.
It also happens with GLES3 in 3.2.4 beta builds (tested 68973ca) as they now extend the batching to GLES3 too.

Disabling batching solves it both for GLES2 and GLES3.

@Zoomulator
Copy link
Author

@akien-mga Yep, confirmed that disabling batching works in my project. Thanks for the feedback!

@lawnjelly
Copy link
Member

K I'll take a look. 👍

@lawnjelly
Copy link
Member

Ok got renderdoc installed, it looks like it is capturing the backbuffer twice, so the last version is when both rects are drawn (instead of just one capture with the first). This is probably due to the rects being batched together. This may not be too tricky to fix after all. 👍

@akien-mga
Copy link
Member

Fixed by #43818.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants