Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on res:// folder is very slow #66901

Closed
KoBeWi opened this issue Oct 4, 2022 · 7 comments 路 Fixed by #71441
Closed

Clicking on res:// folder is very slow #66901

KoBeWi opened this issue Oct 4, 2022 · 7 comments 路 Fixed by #71441

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Oct 4, 2022

Godot version

0056acf

System information

Windows 10 x64

Issue description

When you click res:// folder in filesystem dock, it hangs the editor for a few seconds:
godot_96GEUSbke2
(this is release build)

Steps to reproduce

  1. Click res://
  2. 馃ザ

Minimal reproduction project

No response

@Mickeon
Copy link
Contributor

Mickeon commented Oct 5, 2022

It may be a regression of Tree itself, but I can't figure this one out. There's a lot of slow calls happening specifically when selecting the root TreeItem, and it may only be most noticeable on the FileSystem because there's a lot of... TreeItem children.

@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 11, 2022

Doesn't seem to be happening anymore.

@KoBeWi KoBeWi closed this as completed Oct 11, 2022
@KoBeWi
Copy link
Member Author

KoBeWi commented Oct 13, 2022

No it's still happening, but it's not obvious. You need to click another folder first and then right-click the res://. Subsequent clicks don't cause freeze.

@KoBeWi KoBeWi reopened this Oct 13, 2022
@radlotus
Copy link

radlotus commented Nov 10, 2022

I noticed that in Godot 4 selecting a TreeItem causes a huge spike in "Physics Time" in the Profiler unlike in Godot 3. On my low-end hardware selecting an item within 10 000 items in Godot 4 causes a ~700ms delay while in Godot 3 it's instantaneous.
The Tree node is generally significantly slower in Godot 4 than in Godot 3.

@Maran23
Copy link
Contributor

Maran23 commented Dec 16, 2022

This also happens with the scene tree editor, not even a big one.
I agree to @radlotus, the tree is significantly slower and feels more sluggish on Godot 4.
So the task would be to find and improve the performance bottlenecks of Tree/TreeItem in general.

@Zireael07
Copy link
Contributor

I've been feeling that the remote tree is more sluggish in 4 than in 3.x, and kept wondering why. This looks like it might be the culprit...

@KoBeWi
Copy link
Member Author

KoBeWi commented Jan 14, 2023

Regression from #41242
Clicking res:// will recursively scan every file in the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants