Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot was supposed to have no jokes #69420

Open
MewPurPur opened this issue Nov 30, 2022 · 12 comments
Open

Godot was supposed to have no jokes #69420

MewPurPur opened this issue Nov 30, 2022 · 12 comments

Comments

@MewPurPur
Copy link
Contributor

MewPurPur commented Nov 30, 2022

Godot version

All versions

System information

All systems

Issue description

When I found out that my printer can't throw ERR_PRINTER_ON_FIRE I was going to report it, however, I was told that the error message is just a joke. But in this twitter thread, lead developer Reduz said that no jokes is best, so I don't think it's intentional.

Steps to reproduce

  1. Set a printer on fire
  2. Try to access the printer and notice that ERR_PRINTER_ON_FIRE is not thrown.

/parody

Minimal reproduction project

the steps are trivial

(sorry if this is disrespectful, I just thought we could celebrate this milestone with a small laugh!)

@bend-n
Copy link
Contributor

bend-n commented Nov 30, 2022

you waited for this

@MewPurPur
Copy link
Contributor Author

It's 1:30 AM. Worth it

@bend-n
Copy link
Contributor

bend-n commented Nov 30, 2022

i was about to make a issue lol, i got #69421

@pseidemann
Copy link

Joke requests should be made in the Godot Probrosals repository. Specifically, you should open a discussion in the proposals rejokitory.

This space is for bug regerts only.

@daveTheOldCoder
Copy link

daveTheOldCoder commented Dec 1, 2022

you should open a discussion

Wouldn't it be a discursion?

@adamscott
Copy link
Member

adamscott commented Dec 1, 2022

To cite LICENSE.txt:

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

Henceforth, you cannot sue the Godot Foundation, or neither W4Games and the authors for damages to your printer.

@dalexeev
Copy link
Member

dalexeev commented Dec 1, 2022

I would support removing the error code. I'm not against easter eggs, but when there is a note "(This is an easter egg, no engine methods return this error code.)", then 1. it's not so funny anymore; 2. the question arises whether this joke is appropriate if it needs to be explained. "This APT has Super Cow Powers", without "(This is just a joke, there is no super power in APT actually.)".

@Riteo
Copy link
Contributor

Riteo commented Dec 1, 2022

but when there is a note "(This is an easter egg, no engine methods return this error code.)", then 1. it's not so funny anymore; 2. the question arises whether this joke is appropriate if it needs to be explained.

Definitely agree, this note should be removed while keeping only the "printer on fire" part. Even if people were to take this seriously, it would do no harm.

@mrjustaguy
Copy link
Contributor

mrjustaguy commented Dec 1, 2022

This error should be displayed when you use print too much

@adamscott
Copy link
Member

Definitely agree, this note should be removed while keeping only the "printer on fire" part. Even if people were to take this seriously, it would do no harm.

I want a PR for that issue to be resolved!

@Kubulambula
Copy link
Contributor

Can someone please resolve this issue?

I rely on Godot telling me the status of my printers at my print farm (corporate contract to print this immage over 80085 times) and if one of my printers chatches fire and I wouldn't be notified in time, it would be a huge problem.

@Chaosus Chaosus added this to the 4.0 milestone Dec 2, 2022
@aaronfranke aaronfranke removed this from the 4.0 milestone Dec 6, 2022
@aaronfranke
Copy link
Member

Here's a branch that implements one possible fix to this issue https://github.com/aaronfranke/godot/tree/printer-on-fire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.