Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete type error when compiling unit tests #80421

Closed
timothyqiu opened this issue Aug 8, 2023 · 1 comment · Fixed by #80422
Closed

Incomplete type error when compiling unit tests #80421

timothyqiu opened this issue Aug 8, 2023 · 1 comment · Fixed by #80422

Comments

@timothyqiu
Copy link
Member

Godot version

master [f7bc653]

System information

Arch Linux (GCC 13.2.1)

Issue description

Output:

In file included from tests/test_main.cpp:118:
./tests/servers/rendering/test_shader_preprocessor.h: In function 'bool TestShaderPreprocessor::is_operator_char(unsigned char)':
./tests/servers/rendering/test_shader_preprocessor.h:55:34: error: variable 'const std::string operators' has initializer but incomplete type
   55 |         static const std::string operators = "<>=+-*/";
      |                                  ^~~~~~~~~
./tests/servers/rendering/test_shader_preprocessor.h:56:50: error: incomplete type 'std::string' {aka 'std::__cxx11::basic_string<char>'} used in nested name specifier
   56 |         return operators.find(c) != std::string::npos;
      |                                                  ^~~~
scons: *** [tests/test_main.linuxbsd.editor.dev.x86_64.san.o] Error 1
scons: building terminated because of errors.

Steps to reproduce

Compile the project. Probably needs GCC 13.

Minimal reproduction project

N/A

@AThousandShips
Copy link
Member

AThousandShips commented Aug 8, 2023

Looks like a std::string slipped through the review process, I don't think it should be that but String

From: #74737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants