Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My game causes an error upon exiting when it does not have an audio device connected #89553

Open
Tracked by #76797
kkjinping opened this issue Mar 16, 2024 · 1 comment

Comments

@kkjinping
Copy link

kkjinping commented Mar 16, 2024

Tested versions

4.3 dev 5

System information

Godot v4.3.dev5.mono - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3070 (NVIDIA; 31.0.15.5176) - Intel(R) Core(TM) i7-9700KF CPU @ 3.60GHz (8 Threads)

Issue description

My game causes an error upon exiting when it does not have an audio device connected.

Turning on my speaker works normally if there is an audio device connected.

QQ截图20240316112229

Steps to reproduce

  1. start
  2. exit
  3. error

Minimal reproduction project (MRP)

N/A

@kkjinping kkjinping changed the title My computer causes an error upon exiting when it does not have an audio device connected My Game causes an error upon exiting when it does not have an audio device connected Mar 16, 2024
@kkjinping kkjinping changed the title My Game causes an error upon exiting when it does not have an audio device connected My game causes an error upon exiting when it does not have an audio device connected Mar 16, 2024
@jsjtxietian
Copy link
Contributor

I guess we can remove the ERR_FAIL_COND_V(hr != S_OK, ERR_CANT_OPEN); in AudioDriverWASAPI::audio_device_init, it's checked at outside anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants