Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileDialog confirmation behavior is misleading #90700

Open
JanisMancevics opened this issue Apr 15, 2024 · 0 comments
Open

FileDialog confirmation behavior is misleading #90700

JanisMancevics opened this issue Apr 15, 2024 · 0 comments

Comments

@JanisMancevics
Copy link

JanisMancevics commented Apr 15, 2024

Tested versions

  • Reproducible in Godot Engine v4.2.1.stable.official

System information

Fedora Linux 39 - Wayland - Godot Engine v4.2.1.stable.official (Vulkan Forward+)

Issue description

Issue is that confirmed signal is emitted even if the ConfirmationDialog that appears isn't confirmed (saying that file will be overwritten or that no file name is provided).

Other related issues that may deserve their own tickets is that there doesn't seem to be API to connect to the child ConfirmationDialog buttons (see how it now can be done in the attached project).
And confirmation signal is not being emitted after double clicking on a file name, yet the overwrite ConfirmationDialog does show up.

I guess this all could be categorized as a missing feature, but even if it's not a bug per say it will very likely lead to bugs in user code.

Steps to reproduce

Use the attached reproduction project.
Click the "Save" button.
Either don't select anything and not enter any file name or select any file that is listed.
Confirm the choice.
Look at the Godot editor output log for relevant information.
The print will appear before the choice is confirmed in the popup ConfirmationDialog
Check also the "control.gd" script to get a better picture of what is going on, you can also uncomment there example of how the problem could be solved for now on user side.
You can also double click on any file and observe that nothing is printed at all.

Minimal reproduction project (MRP)

FileDialogIssues.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants