Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example lexer can be simplified #37

Closed
martin-t opened this issue May 22, 2019 · 1 comment
Closed

Example lexer can be simplified #37

martin-t opened this issue May 22, 2019 · 1 comment

Comments

@martin-t
Copy link

martin-t commented May 22, 2019

There is no need to return text from the lexer manually - the lexer already returns a tuple with all the info needed to advance remaining and figure out the span after every token. That way the lexer looks much cleaner.

I can submit a PR if you're interested.

@goffrie
Copy link
Owner

goffrie commented Jun 16, 2019

Good point. Things are much nicer your way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants