You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The latest testify release added a notice against using require inside a goroutine. This is something covered by testify-lint through the go-require rule which is enabled by default. This rule was disabled during golangci-lint upgrade in #2842
A secondary benefit of this is that it forces you to handle goroutines in a more deterministic way (eg using channels).
I've seen people incorrectly assume that their goroutines are finishing by the time the test ends when in reality the test is just exiting before the assertion is run.
@nickajacks1 Yeah, definitely. I'm trying to fix the failing Client test using a channel. The proxy test failing was caused because it was using the default Timeout value for app.Test().
Bug Description
The latest
testify
release added a notice against usingrequire
inside a goroutine. This is something covered bytestify-lint
through thego-require
rule which is enabled by default. This rule was disabled during golangci-lint upgrade in #2842The following tests are failing:
Partly fixed by #2874
Testify Notice: stretchr/testify#1392
How to Reproduce
N/A
Expected Behavior
N/A
Fiber Version
v3.0.0
Code Snippet (optional)
No response
Checklist:
The text was updated successfully, but these errors were encountered: