Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtask: replace --save-blocks, --replay-blocks #234

Open
Tracked by #430
tbfleming opened this issue Nov 22, 2022 · 2 comments
Open
Tracked by #430

Subtask: replace --save-blocks, --replay-blocks #234

tbfleming opened this issue Nov 22, 2022 · 2 comments
Labels
Node infra Related to the necessary infrastructure provided by all psibase infrastructure providers

Comments

@tbfleming
Copy link
Member

No description provided.

@swatanabe
Copy link
Collaborator

I'd prefer to remove them.

  • --save-blocks is unnecessary because it can be fully implemented via the WASM HTTP API. There's no good reason to block the main thread for it. It's also really inflexible to run it only at startup.
  • --replay-blocks: I'd prefer to have this be psibase import <filename>. I also think that this should not be the recommended approach to creating a new node. If downloading the blocklog over p2p is significantly slower than downloading it via some other mechanism, we should ask ourselves why that is the case, and fix it.

@tbfleming tbfleming changed the title Fix --save-blocks, --replay-blocks Replace --save-blocks, --replay-blocks Nov 22, 2022
@tbfleming
Copy link
Member Author

Agreed

@James-Mart James-Mart modified the milestones: R4 - FG, R1 Jul 10, 2023
@James-Mart James-Mart changed the title Replace --save-blocks, --replay-blocks Subtask: replace --save-blocks, --replay-blocks Jul 13, 2023
@James-Mart James-Mart removed this from the R1 milestone Jul 13, 2023
@James-Mart James-Mart added the Node infra Related to the necessary infrastructure provided by all psibase infrastructure providers label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Node infra Related to the necessary infrastructure provided by all psibase infrastructure providers
Projects
None yet
Development

No branches or pull requests

3 participants