Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psibase command line interface #379

Open
swatanabe opened this issue Apr 5, 2023 · 1 comment
Open

psibase command line interface #379

swatanabe opened this issue Apr 5, 2023 · 1 comment
Labels
Node infra Related to the necessary infrastructure provided by all psibase infrastructure providers
Milestone

Comments

@swatanabe
Copy link
Collaborator

swatanabe commented Apr 5, 2023

  • I would expect --sign and --sender to be specified at the same scope because they are closely related.
  • There's no coherent logic to which options must come before the subcommand and which options must come after the subcommand. I'd prefer to get rid of the order restrictions entirely and allow any option to appear anywhere. Failing that, all options should at least always be allowed after the subcommand (I believe that clap uses the attribute from_global to specify this behavior).
  • Several options, (-k, -S, -i) are used by multiple subcommands. I'd like to hoist them to have a common definition.
  • Instead of -i, I think it would be more intuitive to use -f/--force (which is the standard for overriding "helpful" restrictions) combined with either no -k or -k "" (an empty key)
  • upload-tree doesn't need to be a separate command. It can be upload -r, upload --recursive, or just assumed to be recursive if the source is a directory.
@James-Mart
Copy link
Member

Removed

The Content-Type for upload should be optional and should be deduced in the same way as upload tree

In favor of separate issue #390

@James-Mart James-Mart added this to the R2 milestone Jul 10, 2023
@James-Mart James-Mart added the Node infra Related to the necessary infrastructure provided by all psibase infrastructure providers label Aug 29, 2023
@James-Mart James-Mart modified the milestones: R2, R3 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Node infra Related to the necessary infrastructure provided by all psibase infrastructure providers
Projects
None yet
Development

No branches or pull requests

2 participants