-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixed pointer and value recivers #130
Comments
https://go.dev/tour is a beginners tutorial to the language. Does it cause any demonstrable issues? |
I'll second this point. Much of the code in this repo came from github.com/satori/go.uuid so we (the current maintainers) aren't fully responsible for the decisions that were made there. I'd argue against making a purely cosmetic change for this. FWIW, I'd support following this "rule" for any new code. |
Pointer receiver means that instance can be nil instead of value receiver which cause segfault in that situation. |
There are much better UUID library. |
https://github.com/gofrs/uuid/blob/22c52c268bc0dcc0569793f5b1433db423f5a9c6/uuid.go#L286C1-L286C36
according to https://go.dev/tour/methods/8
The text was updated successfully, but these errors were encountered: