Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log client_ip with real ip value #209

Closed
sk1m opened this issue Sep 8, 2022 · 2 comments · Fixed by #210
Closed

Log client_ip with real ip value #209

sk1m opened this issue Sep 8, 2022 · 2 comments · Fixed by #210
Labels
enhancement New feature or request
Projects
Gatekeeper
Milestone
1.7.0

Comments

@sk1m
Copy link

sk1m commented Sep 8, 2022

Log client_ip with real ip value

Summary

Set field value "client_ip" to real ip when logging.

Why?

Currently, field client_ip has value of RemoteAddr, which can be unuseful if gatekeeper placed behind another proxy.

How

Use utils.RealIP result for "client_ip" field value.

Acceptance criteria

Additional Information
sk1m pushed a commit to sk1m/gatekeeper that referenced this issue Sep 8, 2022
log client_ip field with real ip value (gogatekeeper#209)
abe46de
sk1m pushed a commit to sk1m/gatekeeper that referenced this issue Sep 8, 2022
log client_ip field with real ip value (gogatekeeper#209)
d547618
@sk1m sk1m mentioned this issue Sep 8, 2022
Merged
2 tasks
sk1m pushed a commit to sk1m/gatekeeper that referenced this issue Sep 8, 2022
log client_ip field with real ip value (gogatekeeper#209)
31cb284
@p53
Copy link

p53 commented Sep 9, 2022

@sk1m understand why it is useful but what if you want to e.g. log both

@p53 p53 added the enhancement New feature or request label Sep 9, 2022
@p53 p53 added this to To do in Gatekeeper via automation Sep 9, 2022
@p53 p53 added this to the 1.7.0 milestone Sep 9, 2022
sk1m pushed a commit to sk1m/gatekeeper that referenced this issue Sep 9, 2022
log client_ip field with real ip value (gogatekeeper#209)
b79e6da
@sk1m
Copy link
Author

sk1m commented Sep 9, 2022

@p53 agree, much better will be write both

sk1m pushed a commit to sk1m/gatekeeper that referenced this issue Sep 9, 2022
log client_ip field with real ip value (gogatekeeper#209)
d324a0d
sk1m pushed a commit to sk1m/gatekeeper that referenced this issue Sep 9, 2022
log client_ip field with real ip value (gogatekeeper#209)
40dda27
p53 pushed a commit that referenced this issue Sep 9, 2022
log client_ip field with real ip value (#209) (#210)
5c13a19
@p53 p53 linked a pull request Sep 9, 2022 that will close this issue
log client_ip field with real ip value (#209) #210
Merged
2 tasks
@p53 p53 closed this as completed Sep 9, 2022
Gatekeeper automation moved this from To do to Done Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Gatekeeper
Done
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

log client_ip field with real ip value (#209) sk1m/gatekeeper
2 participants
@p53 @sk1m