log client_ip field with real ip value (#209) #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think it would be better to log both, +1 for pull request+tests |
|
@p53 changed to log both, thanks |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| r.log.Debug("upgrading the connnection", zap.String("client_ip", req.RemoteAddr)) | ||
| clientIP := utils.RealIP(req) | ||
| r.log.Debug("upgrading the connnection", | ||
| zap.String("client_ip", clientIP), |
Check failure
Code scanning / CodeQL
Log entries created from user input
|
|
||
| scope.Logger.Debug( | ||
| "incoming authorization request from client address", | ||
| zap.Any("access_type", accessType), | ||
| zap.String("auth_url", authURL), | ||
| zap.String("client_ip", req.RemoteAddr), | ||
| zap.String("client_ip", clientIP), |
Check failure
Code scanning / CodeQL
Log entries created from user input
| scope.Logger.Error(errorMsg, | ||
| zap.String("client_ip", req.RemoteAddr), | ||
| zap.String("client_ip", clientIP), |
Check failure
Code scanning / CodeQL
Log entries created from user input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log client_ip field with real ip value (#209)
Summary
Type
[] Bug fix
[] Feature request
[+] Enhancement
[] Docs
Why?
Requirements
How to try it?
Documentation
Additional Information
Checklist: